Skip to content

AppImage: .DirIcon is missing #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marchellodev opened this issue Apr 23, 2020 · 37 comments
Closed

AppImage: .DirIcon is missing #409

marchellodev opened this issue Apr 23, 2020 · 37 comments
Assignees
Labels
bug Something isn't working hover

Comments

@marchellodev
Copy link

When trying to submit AppImage to AppImageHub, I am having this error:

FATAL: .DirIcon is missing in /tmp/.mount_BeingTQfaB4a

(link to a full log)

@provokateurin
Copy link
Member

That's known. I'm not sure how to fix it, because there is a lack of documentation about that. I hope I can comeup with a solution in the next few days, but I can't promise anything

@provokateurin provokateurin self-assigned this Apr 23, 2020
@provokateurin provokateurin changed the title Problem with AppImage AppImage: .DirIcon is missing Apr 23, 2020
@provokateurin
Copy link
Member

@marchellodev Another thing to mention: You app uses a very old hover version. You can update it (same go get command as to install) and then reinit the project rm go && hover init. In the latest version you can control a lot of names for like the application, executable and the package. That won't fix your problem, but it gives you a lot more features!

@marchellodev
Copy link
Author

marchellodev commented Apr 23, 2020

@jld3103 is there a way to check the installed version of hover?
hover --version doesn't work

upd: Yep, got it, thank you

@provokateurin
Copy link
Member

Maybe @probonopd could you explain to me how to create a correct .DirIcon? I understand if that's not your matter, but there is so little documentation on how to do that.

@probonopd
Copy link

Simply place a png in a Linux standard icon size (e.g., 128x128px) in .DirIcon into the AppDir root directory. Normally tools that produce AppDirs/AppImages should do this automatically, e.g., by copying the icon specified in the desktop file Icon=... key there.

@provokateurin
Copy link
Member

Ok thanks. I hope that works

@provokateurin
Copy link
Member

@probonopd This document says that it needs be a symlink. That was what I tried, but I didn't get it to work. I think that document is outdated.

@provokateurin
Copy link
Member

@probonopd I'm using this command: cp build/assets/icon.png .DirIcon && appimagetool .. I copies a png icon with the size of 256x256 to the .DirIcon and then builds the AppImage, but still I get this error message:

WARNING: No icons found at "usr/share/icons"
WARNING: Using .DirIcon as default app icon
ERROR: Unable to load image.
ERROR: No icon was generated for: /home/jld3103/Applications/gofluttertest-1.0.0+1_9ddc72cafd2a928b3f181bb797aac3bd.AppImage
Segmentation fault (core dumped)

@probonopd
Copy link

probonopd commented Apr 23, 2020

Please also copy the icon to usr/share/icons/hicolor/256x256/apps/flutter.png if your desktop file has Icon=flutter. Which tool are you using that is saying "ERROR: Unable to load image."?

@provokateurin
Copy link
Member

Just launching the AppImage from the command line and then clicking on integrate and run. I guess that means it's running using appimaged?

@probonopd
Copy link

@probonopd
Copy link

@probonopd This document says that it needs be a symlink.

Changed, as I could not find anything in the ROX AppDir description that would indicate it needs to be a symlink.

@provokateurin
Copy link
Member

@probonopd This is the full application with the correct icon layout (now files but also tried with symlinks, but got the same result).
Now an icon is shown on the file and running once still works, but when trying to integrate it it fails with Segmentation fault (core dumped). Nothing more. I guess then it's not an appimage error rather than an appimagelauncher error, right?

hover-build-go_flutter_test-linux-appimage277435954.tar.gz

@marchellodev
Copy link
Author

@probonopd @jld3103 any updates?

@provokateurin
Copy link
Member

I'm not sure how to proceed or even if the error I encounter is the same that you encouter

@probonopd
Copy link

probonopd commented May 2, 2020

@jld3103

hover-build-go_flutter_test-linux-appimage277435954.tar.gz

This is an AppDir, not an AppImage.

When I convert it to an AppImage like this:

wget -c https://github.com/$(wget -q https://github.com/probonopd/go-appimage/releases -O - | grep "appimagetool-.*-x86_64.AppImage" | head -n 1 | cut -d '"' -f 2)
chmod +x appimagetool-*.AppImage
ARCH=x86_64 VERSION=1 ./appimagetool-446-x86_64.AppImage ./hover-build-go_flutter_test-linux-appimage277435954

the AppImage works well on Xubuntu 18.04.4 LTS, and it has the correct icon when the optional appimaged daemon is used for desktop integration (rather than AppImageLauncher which I don't use) both in the file manager and in the menu:

icon

menu

So I think the AppImage is fine as it is, for a final check please submit it to AppImageHub so that the automated tests can run. Thank you very much 👍

If there are issues with AppImageLauncher please discuss them in https://github.com/TheAssassin/AppImageLauncher.

@provokateurin
Copy link
Member

Ok nice thanks. I'm not sure if I didn't read the documentation or if the documentation was wrong. Anyway I'm glad you helped me

@provokateurin
Copy link
Member

provokateurin commented May 2, 2020

@probonopd Now I used appimaged (also uninstalled appimagelauncher) and put the AppImage under $HOME/Applications and ran appimaged, but got this error message:

appimaged, continuous build (commit b096cd3), build 221 built on 2020-03-30 19:16:46 UTC
Watching /home/jld3103/.local/bin
Watching /home/jld3103/Downloads
Watching /home/jld3103/bin
WARNING: No icons found at "usr/share/icons"
WARNING: Using .DirIcon as default app icon
Segmentation fault (core dumped)

I'm using the normal appimagetool and not the go appimagetool. That shouldn't make a difference, right?

@provokateurin
Copy link
Member

When using the go-appimagetool I get this:

appimaged, continuous build (commit b096cd3), build 221 built on 2020-03-30 19:16:46 UTC
Watching /home/jld3103/.local/bin
Watching /home/jld3103/Downloads
Watching /home/jld3103/bin
Extracting usr/share/icons/hicolor/256x256/apps/go_flutter_test.png to "/home/jld3103/.local/share/icons/hicolor/256x256/apps/appimagekit_3cac35213efbe4940e6536e23f10ff3b_go_flutter_test.png"
Segmentation fault (core dumped)

@probonopd
Copy link

I'm happy to look into this but please do open issues in the respective projects (the ones that crash) so that we don't mix up different things.

@provokateurin
Copy link
Member

provokateurin commented May 2, 2020

I'm not sure if appimagelauncher and appimaged are the problems. Maybe it's just my wrong packaging?
I still have some things to try before opening a new issue.

@provokateurin
Copy link
Member

Ok I'm getting some error logs. I'll try to fix them and hope that it works then. Let's see

@provokateurin
Copy link
Member

But odd that the go-appimagetool reports misconfiguration while the normal appimagetool doesn't.

@provokateurin
Copy link
Member

Still the same. No clue what to do now.

@probonopd
Copy link

If you can write something down that I can reproduce I'll gladly help. (Especially since I am essentially moving everything to Go right now.)

@provokateurin
Copy link
Member

I'll try

@provokateurin
Copy link
Member

@probonopd With that PR the tool generates the attached folder and the packages it. After copying the AppImage to ~/Applications and I run appimaged and get this error:

appimaged, continuous build (commit b096cd3), build 221 built on 2020-03-30 19:16:46 UTC
Watching /home/jld3103/.local/bin
Watching /home/jld3103/Downloads
Watching /home/jld3103/bin
Extracting usr/share/icons/hicolor/256x256/apps/go_flutter_test.png to "/home/jld3103/.local/share/icons/hicolor/256x256/apps/appimagekit_0119f5b16156d92850d361fa897d0634_go_flutter_test.png"
Segmentation fault (core dumped)

Can you reproduce it?
This is no information about the error, but I hope you can confirm that there is an error.
hover-build-go_flutter_test-linux-appimage928923469.tar.gz

@provokateurin
Copy link
Member

@marchellodev Can you try go-flutter-desktop/hover#115 and submit the AppImage to try if the check still fails? (You have to clone the branch and do a go install. To go back just follow the install steps again)

@provokateurin provokateurin added the bug Something isn't working label May 6, 2020
@marchellodev
Copy link
Author

@provokateurin
Copy link
Member

I think is not the fault of go-flutter or hover.
./build/sharik: /lib/x86_64-linux-gnu/libm.so.6: version 'GLIBC_2.27' not found (required by ./build/sharik) indicates that there is something wrong with the glibc version

@probonopd
Copy link

probonopd commented May 7, 2020

@probonopd With that PR the tool generates the attached folder and the packages it. After copying the AppImage to ~/Applications and I run appimaged and get this error:

From the message above, it looks like you are running into an issue in

appimaged, continuous build (commit b096cd3), build 221 built on 2020-03-30 19:16:46 UTC

Please report over at https://github.com/AppImage/appimaged/issues.

I am using https://github.com/probonopd/go-appimage/tree/master/src/appimaged instead and as written and shown in #5, it works well there. So it seems https://github.com/AppImage/appimaged has a bug which https://github.com/probonopd/go-appimage/tree/master/src/appimaged does not have.

@marchellodev
Copy link
Author

This was built on Ubuntu 16.04 with @jld3103's pull request https://travis-ci.org/github/AppImage/appimage.github.io/builds/685028088

@marchellodev
Copy link
Author

When trying to run it: Segmentation fault and that's it

@provokateurin
Copy link
Member

That error is completely different from what this issue is about.
Can we close this when go-flutter-desktop/hover#115 is merged and you open a new issue?

@marchellodev
Copy link
Author

Ok, that's fine

@provokateurin
Copy link
Member

Merged in go-flutter-desktop/hover@b9d881b
It is not published yet, because there are going to be some changes, but if you want the fixed version you can clone the hover repo and do a go install.
I will closes this issue, because the original error is fixed.

@GeertJohan
Copy link
Member

If you do a go install, be sure to also locally create the docker image if you'd like to use --docker.

The easiest way to do that is to read and run install-with-docker-image.sh in the root of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hover
Development

Successfully merging a pull request may close this issue.

4 participants