Release builds #156

arcticfox1919 · 2019-06-09T15:16:39Z

I use the hover build command to generate a Windows executable, but there is a black console, how to publish a real program without a console.

The text was updated successfully, but these errors were encountered:

GeertJohan · 2019-06-09T16:04:24Z

We don't have support for releases yet. For now, hover only builds a debug version of the app with a console to track logs. I'll keep this issue open to track support for release builds.

GeertJohan · 2019-06-10T10:21:04Z

Things that --release should do:

Build binary without console (windows: -ldflags -H=windowsgui).
Building flutter bundle as --release.
Setting the right VM arguments.
Reduce the size of the share-lib from 88M to 28M by running strip -s ./libflutter_engine.so.

erickzanardo · 2019-06-21T13:43:02Z

I am really looking forward to this as well.

chengxuncc · 2019-06-26T03:52:45Z

Can't wait to play with it.

alexelisenko · 2019-06-26T12:45:47Z

@GeertJohan Any updates or ETA on this? If not, would you be able to provide any documentation on how to go about removing the console window manually for now? It would be greatly appreciated.

Thanks.

pchampio · 2019-06-26T12:52:13Z

Once my final exams are over, I'll like to take a look at release builds, (if it's not done by then).
For now, #135 provides enough information for you to hack this through.

$ # export CGO_LDFLAGS="-L$HOME/.cache/hover/engine/windows/" # Not working!
$ # set CGO_LDFLAGS="-L%HOMEPATH%/.cache/hover/engine/windows/" # also not working the dll isn't found
$ cd ./desktop/cmd
$ go build -ldflags="-L%HOMEPATH%/.cache/hover/engine/windows/" -H=windowsgui
$ mv cmd ../build/outputs/windows
$ ../build/outputs/windows/cmd # to start the app

alexelisenko · 2019-06-26T13:10:46Z

@Drakirus Thanks for that. Im assuming its supposed to be set vs export for windows?

pchampio · 2019-06-26T13:12:09Z

Yup

alexelisenko · 2019-06-26T13:15:58Z

Im getting the following error:

PS C:\Users\User\development\desktop-apps\flutter_project> set CGO_LDFLAGS="-L%HOMEPATH%/.cache/hover/engine/windows/"
PS C:\Users\User\development\desktop-apps\flutter_project> cd ./desktop/cmd
PS C:\Users\User\development\desktop-apps\flutter_project\desktop\cmd> go build -ldflags -H=windowsgui
# github.com/go-flutter-desktop/go-flutter/embedder
C:/Program Files/mingw-w64/x86_64-8.1.0-posix-seh-rt_v6-rev0/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/8.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lflutter_engine
collect2.exe: error: ld returned 1 exit status

pchampio · 2019-06-26T13:17:37Z

#34 (comment) will have your back

alexelisenko · 2019-06-26T13:36:19Z

@Drakirus That worked, thank you!

For anyone having this issue, copying the flutter_engine.dll file to the lib folder of minwg did the trick.

windows env var command:

set CGO_LDFLAGS="-L%HOMEPATH%/.cache/hover/engine/windows/"

chengxuncc · 2019-06-26T19:17:23Z

It doesn't work

$ set CGO_LDFLAGS="-L%HOMEPATH%/.cache/hover/engine/windows/"
$ go build -ldflags -H=windowsgui
# runtime/cgo
gcc: error: "-L\Users\cheng/.cache/hover/engine/windows/": Invalid argument

I just copy flutter_engine.dll to {mingw64 installation place}\lib and it works.

cd ./desktop/cmd
go build -ldflags -H=windowsgui
mv cmd ../build/outputs/windows
../build/outputs/windows/cmd

alexelisenko · 2019-07-06T00:12:49Z

@Drakirus When building for OSX with hover, it seems as though the -mmacosx-version-min gcc flag is not being set, how would I go about making hover set it?

pchampio · 2019-07-06T09:43:50Z

@alexelisenko I don't know much.
I've read https://stackoverflow.com/questions/37399813/why-is-go-build-executable-not-working-on-osx-10-7-or-below-with-third-party-lib
didn't found any answers 😕

monkeyWie · 2019-07-07T14:48:18Z

Things that --release should do:

Build binary without console (windows: -ldflags -H=windowsgui).

Building flutter bundle as --release.

Setting the right VM arguments.

Reduce the size of the share-lib from 88M to 28M by running strip -s ./libflutter_engine.so.

How is the progress of this feature? I am looking expectantly toward the feature.
And use -ldflags "-s -w -H=windowsgui" could reduce the size even more.

chunhunghan · 2019-07-08T01:00:55Z

For Windows

cd C:\your_project_dir\desktop\cmd
C:\your_project_dir\desktop\cmd>go build -ldflags -H=windowsgui
C:\your_project_dir\desktop\cmd>move cmd.exe ../build/outputs/windows
C:\your_project_dir\desktop\build\outputs\windows\cmd.exe

Thank you all. you are amazing.

GeertJohan · 2019-07-10T08:08:41Z

FYI, Work in progress in branch feature/release, not completed yet.

pchampio · 2019-07-23T15:39:50Z

go-flutter-desktop/hover#11 got merged!
Hover, when building the app with hover build will create the app in release mode!

pchampio · 2019-07-23T15:43:55Z

Updates on hover occurs, make sure to run go get -u github.com/go-flutter-desktop/hover every once in a while.

ghost · 2019-07-29T16:02:02Z

Does Mac and Linux supported yet? Still get console windows in mac.

pchampio · 2019-07-29T16:10:26Z

@deromask: Answer copy/pasted from zserge/webview issue 13:

On windows there are two subsystems, console and windows. They often have two different entry points (main vs WinMain). But on MacOS it's all the same executable.

The reason you see a terminal window is because you launch the binary directly and not as an app bundle.

Try running the following commands:

$ cd desktop/build/outputs/darwin
$ mkdir -p minimal.app/Contents/MacOS
$ cp ${your_app_name} minimal.app/Contents/MacOS/minimal

Now in Finder you should see minimal.app, clicking on that would launch a GUI window without a terminal. Of course, for a more proper app you would also have to add minimal.app/Contents/Info.plist XML file and maybe some minimal.app/Contents/Resources/minimal.icns for icons. But that depends on the way you package/distribute your app, and I don't think library should be responsible for such things.

Some more readings: https://stackoverflow.com/questions/23861914/how-to-hide-terminal-window-in-mac-osx.
The process of building this app bundle is tracked in: #207

ghost · 2019-07-29T16:32:53Z

@Drakirus Thank you very much!

maheshbhattaraai · 2019-08-04T11:35:08Z

How to update previous installed device.

go get -u github.com/go-flutter-desktop/hover

This gives following error

go get -u github.com/go-flutter-desktop/hover
# cd C:\Users\acer\go\src\github.com\go-flutter-desktop\hover; git pull --ff-only
error: Your local changes to the following files would be overwritten by merge:
        assets/app/icon.png
Please commit your changes or stash them before you can merge.
Aborting
package github.com/go-flutter-desktop/hover: exit status 1

Thank You

pchampio · 2019-08-04T12:41:39Z

@maheshbhattaraai

cd C:\Users\acer\go\src\github.com\go-flutter-desktop\hover
git stash
go get -u github.com/go-flutter-desktop/hover

alexelisenko · 2019-08-30T14:15:51Z

@Drakirus Any luck figuring out the -mmacosx-version-min flag issue?

At the moment, it seems to be set to whatever OS version is used to build. I could try setting the ENV variable to CGO_CFLAGS="-mmacosx-version-min=10.11" and do hover build, im just not sure if this variable is overwritten by the hover build process.

alexelisenko · 2019-08-30T14:18:30Z

Perhaps this can be added to: https://github.com/go-flutter-desktop/hover/blob/df3629d6657c7e194f966478c42faa516a545ba4/cmd/build.go#L195

pchampio · 2019-08-30T14:27:31Z

@alexelisenko if you build your own version of hover and add the -mmacosx-version-min=10.11 flag in build.go#L195, does it fixes your issue?

alexelisenko · 2019-08-30T14:49:56Z

I can give it a shot. Would you be able to give instructions on building and using a custom version of hover?

pchampio · 2019-08-30T14:50:57Z

git clone https://github.com/go-flutter-desktop/hover.git cd hover go install

alexelisenko · 2019-08-30T23:08:16Z

I think I have it working, but need to do some more testing.

I had to add the following:

ldflags = append(ldflags, "-extldflags=-mmacosx-version-min=10.11")

and

	cmdGoBuild.Env = append(os.Environ(),
		"GO111MODULE=on",
		"CGO_CFLAGS=-mmacosx-version-min=10.11",
		"CGO_LDFLAGS="+cgoLdflags,
	)

Tokenyet · 2019-09-03T16:44:25Z

Is there a way to use something like ::ShowWindow(::GetConsoleWindow(), SW_HIDE); to hide console? I got a fairly big issue when using release mode.

On debug mode, There is no console window when using dart Process, but on release mode, This is the biggest problem, I use a bunch of Process.run in the background, so It popup up several console in a const interval because Timer.periodic is calling constantly.

Except that, I can't find how to set icon to the final executable, Am I missing something?

By the way, Thanks for this project 👍 , It's awesome.

alexelisenko · 2019-09-03T16:48:52Z

@Tokenyet Does the process you are executing open with a console window (if you run it manually)?

If anyone can correct me if I'm wrong, but, I believe that if you execute a process that opens a console window, that is your issue.

maheshbhattaraai · 2019-09-03T16:53:09Z

You can set your icon with same icon name previously stored inside desktop/assets/.

Tokenyet · 2019-09-03T16:53:45Z

I don't know what you think, but what I mean is If I build a Debug executable, It's only one console, no any popups. This is only happened in Release mode.

Tokenyet · 2019-09-03T16:55:07Z

You can set your icon with same icon name previously stored inside desktop/assets/.

Override icon.png will only replace the icon of the windows bar, not the executable itself in my case.

alexelisenko · 2019-09-03T16:57:04Z

@Tokenyet Have you tried setting the runInShell argument to true?

Tokenyet · 2019-09-03T16:57:24Z

@Tokenyet Have you tried setting the runInShell argument to true?

That's what I'm doing.

Tokenyet · 2019-09-03T17:17:05Z

With the following code, I made It! This is the hiding solution to solve the popup issue.

package main

import "github.com/gonutz/w32"

func main() {
    console := w32.GetConsoleWindow()
    if console != 0 {
        _, consoleProcID := w32.GetWindowThreadProcessId(console)
        if w32.GetCurrentProcessId() == consoleProcID {
            w32.ShowWindowAsync(console, w32.SW_HIDE)
        }
    }
}

reference: https://stackoverflow.com/questions/23250505/how-do-i-create-an-executable-from-golang-that-doesnt-open-a-command-cmd-wind/23250506

Tokenyet · 2019-09-03T17:40:09Z

Sorry, but I can only find the workaround, I think someone would interest on this, so I decided to share here.

For changing executable icon, following the instruction on rc-demo, and run hover build, that's It.

reference: https://stackoverflow.com/questions/25602600/how-do-you-set-the-application-icon-in-golang/49127938#49127938

GeertJohan added enhancement New feature or request hover labels Jun 9, 2019

GeertJohan changed the title ~~How to release my app?~~ Hover build release Jun 10, 2019

GeertJohan pinned this issue Jun 10, 2019

GeertJohan mentioned this issue Jun 10, 2019

Hover: windows #106

Closed

GeertJohan changed the title ~~Hover build release~~ Release builds Jun 10, 2019

GeertJohan mentioned this issue Jul 2, 2019

MacOS Code Signing #179

Closed

pchampio closed this as completed Jul 23, 2019

pchampio unpinned this issue Jul 23, 2019

go-flutter-desktop deleted a comment from maheshbhattaraai Aug 4, 2019

Release builds #156

Release builds #156

Comments

arcticfox1919 commented Jun 9, 2019

GeertJohan commented Jun 9, 2019

GeertJohan commented Jun 10, 2019 • edited by pchampio Loading

erickzanardo commented Jun 21, 2019

chengxuncc commented Jun 26, 2019

alexelisenko commented Jun 26, 2019

pchampio commented Jun 26, 2019 • edited Loading

alexelisenko commented Jun 26, 2019

pchampio commented Jun 26, 2019

alexelisenko commented Jun 26, 2019

pchampio commented Jun 26, 2019 • edited Loading

alexelisenko commented Jun 26, 2019

chengxuncc commented Jun 26, 2019

alexelisenko commented Jul 6, 2019 • edited Loading

pchampio commented Jul 6, 2019 • edited Loading

monkeyWie commented Jul 7, 2019 • edited by pchampio Loading

chunhunghan commented Jul 8, 2019 • edited Loading

GeertJohan commented Jul 10, 2019 • edited Loading

pchampio commented Jul 23, 2019

pchampio commented Jul 23, 2019

ghost commented Jul 29, 2019

pchampio commented Jul 29, 2019 • edited Loading

ghost commented Jul 29, 2019

maheshbhattaraai commented Aug 4, 2019

pchampio commented Aug 4, 2019 • edited Loading

alexelisenko commented Aug 30, 2019

alexelisenko commented Aug 30, 2019

pchampio commented Aug 30, 2019

alexelisenko commented Aug 30, 2019

pchampio commented Aug 30, 2019

alexelisenko commented Aug 30, 2019

Tokenyet commented Sep 3, 2019

alexelisenko commented Sep 3, 2019

maheshbhattaraai commented Sep 3, 2019

Tokenyet commented Sep 3, 2019

Tokenyet commented Sep 3, 2019 • edited Loading

alexelisenko commented Sep 3, 2019

Tokenyet commented Sep 3, 2019

Tokenyet commented Sep 3, 2019 • edited Loading

Tokenyet commented Sep 3, 2019 • edited Loading

GeertJohan commented Jun 10, 2019 •

edited by pchampio

Loading

pchampio commented Jun 26, 2019 •

edited

Loading

pchampio commented Jun 26, 2019 •

edited

Loading

alexelisenko commented Jul 6, 2019 •

edited

Loading

pchampio commented Jul 6, 2019 •

edited

Loading

monkeyWie commented Jul 7, 2019 •

edited by pchampio

Loading

chunhunghan commented Jul 8, 2019 •

edited

Loading

GeertJohan commented Jul 10, 2019 •

edited

Loading

pchampio commented Jul 29, 2019 •

edited

Loading

pchampio commented Aug 4, 2019 •

edited

Loading

Tokenyet commented Sep 3, 2019 •

edited

Loading

Tokenyet commented Sep 3, 2019 •

edited

Loading

Tokenyet commented Sep 3, 2019 •

edited

Loading