Skip to content

TextInputController onSubmitted callback doesn't function. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
james-lawrence opened this issue Sep 13, 2018 · 4 comments
Closed

TextInputController onSubmitted callback doesn't function. #12

james-lawrence opened this issue Sep 13, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@james-lawrence
Copy link
Contributor

havent discovered exactly how this is handled, but its related to #11.

and the answer is probably related to keyboard handler found in the google-desktop-embedding
@pchampio
Copy link
Member

pchampio commented Sep 22, 2018 •
edited
Loading

I am not sure, but it think the onSubmitted callback might be trigger with the keyevents.

@pchampio pchampio added the enhancement New feature or request label Sep 24, 2018
@pchampio
Copy link
Member

pchampio commented Oct 30, 2018 •
edited
Loading

flutter Doc: TextInputClient.performAction and TextInputAction.newline
The the newline action is not sended to the Engine.
Related to: flutter/flutter#23015

@pchampio pchampio reopened this Oct 30, 2018
@pchampio pchampio added the good first issue Good for newcomers label Oct 30, 2018
@TitouanT
Copy link
Contributor

TitouanT commented Nov 13, 2018 •
edited
Loading

The current flutter version used in the project (7.3) doesn't include the fix from flutter/flutter#23015 https://github.com/flutter/flutter/blob/v0.7.3/packages/flutter/lib/src/widgets/editable_text.dart#L511

I will see if everything works with version 10.1 because it's the first version containing the fix.
see https://github.com/flutter/flutter/blob/v0.10.1/packages/flutter/lib/src/widgets/editable_text.dart#L525

@TitouanT TitouanT mentioned this issue Nov 13, 2018
Merged
@pchampio
Copy link
Member

fixed by #26

@winner484 winner484 mentioned this issue Mar 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

No branches or pull requests
3 participants
@james-lawrence @pchampio @TitouanT