Merge pull request #29 from go-flutter-desktop/revert-28-custom_error_codes

Revert "Custom error codes on the plugin side"

Author: pchampio

plugin_tutorial/go-plugin-example/complex/main.go

@@ -21,7 +21,6 @@ func (p *Example) InitPlugin(messenger plugin.BinaryMessenger) error {
 
 	p.channel = plugin.NewMethodChannel(messenger, "instance.id/go/data", plugin.StandardMethodCodec{})
 	p.channel.HandleFunc("getData", getRemotesFunc)
-	p.channel.HandleFunc("getError", getErrorFunc)
 	p.channel.CatchAllHandleFunc(p.catchAllTest)
 
 	return nil
@@ -65,7 +64,3 @@ func getRemotesFunc(arguments interface{}) (reply interface{}, err error) {
 
 	return sectionList, nil
 }
-
-func getErrorFunc(arguments interface{}) (reply interface{}, err error) {
-	return nil, plugin.NewError("customErrorCode", errors.New("Some error"))
-}

plugin_tutorial/lib/main_desktop.dart

@@ -21,38 +21,26 @@ void main() async {
     print(batteryLevel);
   });
 
-  group('Complex plugin', () {
+  // A more complicated plugin
+  //
+  test('Test StandardMethodCodec array of map', () async {
     const platform_complex_structure =
         const MethodChannel('instance.id/go/data');
 
-    // A more complicated plugin
-    test('Test StandardMethodCodec array of map', () async {
-      final List<dynamic> result =
-          await platform_complex_structure.invokeMethod('getData',
-              "HelloFromDart"); // passing "HelloFromDart" as an argument
-      expect(result, [
-        {"instanceid": 1023, "pcbackup": "test", "brbackup": "test2"},
-        {"instanceid": 1024, "pcbackup": "test", "brbackup": "test2"},
-        {"instanceid": 1056, "pcbackup": "coucou", "brbackup": "coucou2"},
-        {"instanceid": 3322, "pcbackup": "finaly", "brbackup": "finaly2"}
-      ]);
-
-      // golang can return the random methodName
-      final String methodName =
-          'test/' + new Random().nextInt(100000).toString();
-      final String resultPathPrefix =
-          await platform_complex_structure.invokeMethod(methodName);
-      expect(resultPathPrefix, methodName);
-    });
-
-    test('Custom errors', () async {
-      var matcher = predicate(
-          (e) => e is PlatformException && e.code == "customErrorCode");
-      expect(
-        platform_complex_structure.invokeMethod('getError'),
-        throwsA(matcher),
-      );
-    });
+    final List<dynamic> result = await platform_complex_structure.invokeMethod(
+        'getData', "HelloFromDart"); // passing "HelloFromDart" as an argument
+    expect(result, [
+      {"instanceid": 1023, "pcbackup": "test", "brbackup": "test2"},
+      {"instanceid": 1024, "pcbackup": "test", "brbackup": "test2"},
+      {"instanceid": 1056, "pcbackup": "coucou", "brbackup": "coucou2"},
+      {"instanceid": 3322, "pcbackup": "finaly", "brbackup": "finaly2"}
+    ]);
+
+    // golang can return the random methodName
+    final String methodName = 'test/' + new Random().nextInt(100000).toString();
+    final String resultPathPrefix =
+        await platform_complex_structure.invokeMethod(methodName);
+    expect(resultPathPrefix, methodName);
   });
 
   tearDownAll(() async {