Skip to content

Commit a1fc7e7

Browse files
author
rcaa
committed
changing Math.random to SecureRandom
1 parent 4365c8f commit a1fc7e7

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/main/java/com/gitblit/models/UserModel.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import java.io.Serializable;
1919
import java.security.Principal;
20+
import java.security.SecureRandom;
2021
import java.util.ArrayList;
2122
import java.util.Collections;
2223
import java.util.HashSet;
@@ -662,6 +663,9 @@ public boolean isMyPersonalRepository(String repository) {
662663
}
663664

664665
public String createCookie() {
665-
return StringUtils.getSHA1(String.valueOf(Math.random()));
666+
SecureRandom random = new SecureRandom();
667+
byte[] values = new byte[20];
668+
random.nextBytes(values);
669+
return StringUtils.getSHA1(String.valueOf(values));
666670
}
667671
}

0 commit comments

Comments
 (0)