Skip to content

Commit 954e228

Browse files
authored
llama : fix typical sampling (#4261)
Typical sampling was broken because after copying new_candidates into canditates, the "sorted" bool is left at "true", but the new data is no longer sorted according to probability. Patch to set "sorted" to false. Test: Generating with temp=0.0001 (approx. argmax) should generate the same sequence at typical>=1.0 and typical=0.9999 (approx. disabled, but enters the typical sampling codepath).
1 parent e2bd725 commit 954e228

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

llama.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7027,6 +7027,7 @@ void llama_sample_typical(struct llama_context * ctx, llama_token_data_array * c
70277027
// Replace the data in candidates with the new_candidates data
70287028
std::copy(new_candidates.begin(), new_candidates.end(), candidates->data);
70297029
candidates->size = new_candidates.size();
7030+
candidates->sorted = false;
70307031

70317032
if (ctx) {
70327033
ctx->t_sample_us += ggml_time_us() - t_start_sample_us;

0 commit comments

Comments
 (0)