From 2f0c01b1cb2de5c33d7369caba96aff283b29e42 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Mon, 24 Mar 2025 13:08:00 +0100 Subject: [PATCH] ref: Stop using `dropUndefinedKeys` in SpanExporter --- packages/opentelemetry/src/spanExporter.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/opentelemetry/src/spanExporter.ts b/packages/opentelemetry/src/spanExporter.ts index e095ab60e805..90a3d890a959 100644 --- a/packages/opentelemetry/src/spanExporter.ts +++ b/packages/opentelemetry/src/spanExporter.ts @@ -19,7 +19,6 @@ import { SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, captureEvent, - dropUndefinedKeys, getCapturedScopesOnSpan, getDynamicSamplingContextFromSpan, getStatusMessage, @@ -274,7 +273,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE]; const responseContext = typeof statusCode === 'number' ? { response: { status_code: statusCode } } : undefined; - const transactionEvent: TransactionEvent = dropUndefinedKeys({ + const transactionEvent: TransactionEvent = { contexts: { trace: traceContext, otel: { @@ -298,7 +297,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve source, }, }), - }); + }; return transactionEvent; } @@ -335,7 +334,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS const status = mapStatus(span); - const spanJSON: SpanJSON = dropUndefinedKeys({ + const spanJSON: SpanJSON = { span_id, trace_id, data: allData, @@ -349,7 +348,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS origin, measurements: timedEventsToMeasurements(span.events), links: convertSpanLinksForEnvelope(links), - }); + }; spans.push(spanJSON);