-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Stop setting event.request
in Browser SDKs
#15845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Awful things:
I feel like we need a spec for a Page context and let relay pick these things up from there. |
There's already a browser context which I'm guessing would be most appropriate to move the user agent to. |
Yup I already have a relay PR upen that is stuck in limbo to backfill the url in the browser context so we can slowly phase out event.request generically: getsentry/relay#4659 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Today, we set data about the current page on
event.request
in the Browser SDK. This is done by the HttpContext integration:In product, we show this as "HTTP Request Information" which is pretty confusing. We should stop setting this for browser SDKs, and instead set this information in a different place (e.g. in a
page
context, TBD).We can then think about instead using this place to store outgoing-request information for failed fetch calls.
The text was updated successfully, but these errors were encountered: