Skip to content

Create a Preview for each PR #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
certik opened this issue Apr 25, 2020 · 6 comments · Fixed by #46 or #54
Closed

Create a Preview for each PR #41

certik opened this issue Apr 25, 2020 · 6 comments · Fixed by #46 or #54

Comments

@certik
Copy link
Member

certik commented Apr 25, 2020

Right now we have to test a PR locally that it works. Our CI should create a preview of each PR, so that we can simply see it right away. Typically that is achieved by pushing the PR into some review github pages as a branch with a url prefix so each PR has its own prefix and we can check that the page looks good.

@certik
Copy link
Member Author

certik commented May 3, 2020

We had to revert the fix, so I am reopening the issue also.

@LKedward
Copy link
Member

LKedward commented May 7, 2020

I think this needs re-opening unfortunately,
Test PR #55 failed to push the preview build to the repo.

There's a permissions problem.

@milancurcic
Copy link
Member

I don't see any failure in that link. What kind of permission is needed?

@LKedward
Copy link
Member

LKedward commented May 7, 2020

I don't see any failure in that link.

Yeah it's a bit annoying, the marketplace action for pushing to the repo completes successfully even if the push failed.
Look under > Commit and push to gh-pages / > Internal logs.

It seems the github action for pull requests from forks only has read-only access.

I think a solution can be to have the preview build triggered explicitly when someone with write access comments #build_pr or something. I will look into this.

@milancurcic
Copy link
Member

If we add you as collaborator with permissions on this repo, would you know how to set it up?

@LKedward
Copy link
Member

LKedward commented May 7, 2020

If we add you as collaborator with permissions on this repo, would you know how to set it up?

Yes I believe so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants