-
Notifications
You must be signed in to change notification settings - Fork 68
Create a Preview for each PR #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We had to revert the fix, so I am reopening the issue also. |
I think this needs re-opening unfortunately, There's a permissions problem. |
I don't see any failure in that link. What kind of permission is needed? |
Yeah it's a bit annoying, the marketplace action for pushing to the repo completes successfully even if the push failed. It seems the github action for pull requests from forks only has read-only access. I think a solution can be to have the preview build triggered explicitly when someone with write access comments |
If we add you as collaborator with permissions on this repo, would you know how to set it up? |
Yes I believe so |
Right now we have to test a PR locally that it works. Our CI should create a preview of each PR, so that we can simply see it right away. Typically that is achieved by pushing the PR into some review github pages as a branch with a url prefix so each PR has its own prefix and we can check that the page looks good.
The text was updated successfully, but these errors were encountered: