Skip to content

Commit 54dd888

Browse files
authored
[flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (#7688)
This PR removes three const lints from package:flutter_lints: `prefer_const_constructors`, `prefer_const_declarations`, and `prefer_const_literals_to_create_immutables`. This PR does not rev the pubspec version. We want to stage this change out in coordination with package:lints; see https://github.com/dart-lang/lints/issues/209. - https://github.com/dart-lang/lints/issues/205 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [Discord]: https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md [linked to at least one issue that this PR fixes]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version [following repository CHANGELOG style]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style [exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog [test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
1 parent 47795ab commit 54dd888

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/flutter_lints/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## NEXT
22

3+
* Removed the following lints:
4+
* `prefer_const_constructors` (see https://github.com/dart-lang/lints/issues/205)
5+
* `prefer_const_declarations`
6+
* `prefer_const_literals_to_create_immutables`
37
* Updates minimum supported SDK version to Flutter 3.19/Dart 3.3.
48

59
## 4.0.0

packages/flutter_lints/lib/flutter.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ linter:
88
- avoid_unnecessary_containers
99
- avoid_web_libraries_in_flutter
1010
- no_logic_in_create_state
11-
- prefer_const_constructors
1211
- prefer_const_constructors_in_immutables
13-
- prefer_const_declarations
14-
- prefer_const_literals_to_create_immutables
1512
- sized_box_for_whitespace
1613
- sort_child_properties_last
1714
- use_build_context_synchronously

0 commit comments

Comments
 (0)