Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 306705c

Browse files
committed
Regres: Fix priority boost for +2 code review.
Confusingly the "Code-Review" label uses 'Value' for -1 / +1, and 'Approved' for +2s. Changes that were ready to land were not being prioritized over no-code review. Change-Id: Ia31adcbbba70b2f52b9abc7299f4bafdcdb8fe48 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27170 Tested-by: Ben Clayton <[email protected]> Reviewed-by: Nicolas Capens <[email protected]>
1 parent 665ee57 commit 306705c

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/regres/main.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,13 +533,17 @@ func (c *changeInfo) update(client *gerrit.Client) error {
533533

534534
kokoroPresubmit := change.Labels["Kokoro-Presubmit"].Approved.AccountID != 0
535535
codeReviewScore := change.Labels["Code-Review"].Value
536+
codeReviewApproved := change.Labels["Code-Review"].Approved.AccountID != 0
536537
presubmitReady := change.Labels["Presubmit-Ready"].Approved.AccountID != 0
537538

538539
c.priority = 0
539540
if presubmitReady {
540541
c.priority += 10
541542
}
542543
c.priority += codeReviewScore
544+
if codeReviewApproved {
545+
c.priority += 2
546+
}
543547
if kokoroPresubmit {
544548
c.priority++
545549
}

0 commit comments

Comments
 (0)