Skip to content

fix: TypeScript declaration return type of Acl.open() #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

harmony7
Copy link
Member

This is a quick fix of the types declaration fix acl.d.ts to fix this error

% npm run build

> prebuild
> tsc

node_modules/@fastly/js-compute/types/acl.d.ts:8:12 - error TS7010: 'open', which lacks return-type annotation, implicitly has an 'any' return type.

8     static open(aclName: string);
             ~~~~


Found 1 error in node_modules/@fastly/js-compute/types/acl.d.ts:8

@harmony7 harmony7 requested a review from guybedford March 13, 2025 06:29
@harmony7 harmony7 changed the title fix: TypeScript declaration return type of Acl.open fix: TypeScript declaration return type of Acl.open() Mar 13, 2025
@guybedford guybedford merged commit b9765f6 into main Mar 13, 2025
24 of 28 checks passed
@guybedford guybedford deleted the kats/types-acl branch March 13, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants