refactor for size

gnoff · gnoff · commit bbf52238d47d · 2022-10-24T16:37:41.000-07:00
diff --git a/packages/react-dom-bindings/src/client/ReactDOMFloatClient.js b/packages/react-dom-bindings/src/client/ReactDOMFloatClient.js
@@ -1470,7 +1470,18 @@ export function isHostResourceType(type: string, props: Props): boolean {
       }
       return (async: any) && typeof src === 'string' && !onLoad && !onError;
     }
-    case 'noscript':
+    case 'noscript': {
+      if (__DEV__) {
+        // This is duplicated from the below case because it minifies in prod better
+        if (resourceFormOnly) {
+          console.error(
+            'Cannot render <%s> outside the main document. Try moving it into the root <head> tag.',
+            type,
+          );
+        }
+      }
+      return true;
+    }
     case 'template':
     case 'style': {
       if (__DEV__) {
@@ -1481,10 +1492,7 @@ export function isHostResourceType(type: string, props: Props): boolean {
           );
         }
       }
-      // For noscript we want it to be a Resource so we can avoid rendering children.
-      // In the future we should move this warning to the server and handle it
-      // separately on the client
-      return type === 'noscript';
+      return false;
     }
   }
   return false;

Original file line number	Diff line number	Diff line change
`@@ -1470,7 +1470,18 @@ export function isHostResourceType(type: string, props: Props): boolean {`
`1470`	`1470`	`}`
`1471`	`1471`	`return (async: any) && typeof src === 'string' && !onLoad && !onError;`
`1472`	`1472`	`}`
`1473`		`- case 'noscript':`
	`1473`	`+ case 'noscript': {`
	`1474`	`+ if (__DEV__) {`
	`1475`	`+ // This is duplicated from the below case because it minifies in prod better`
	`1476`	`+ if (resourceFormOnly) {`
	`1477`	`+ console.error(`
	`1478`	`+ 'Cannot render <%s> outside the main document. Try moving it into the root <head> tag.',`
	`1479`	`+ type,`
	`1480`	`+ );`
	`1481`	`+ }`
	`1482`	`+ }`
	`1483`	`+ return true;`
	`1484`	`+ }`
`1474`	`1485`	`case 'template':`
`1475`	`1486`	`case 'style': {`
`1476`	`1487`	`if (__DEV__) {`
`@@ -1481,10 +1492,7 @@ export function isHostResourceType(type: string, props: Props): boolean {`
`1481`	`1492`	`);`
`1482`	`1493`	`}`
`1483`	`1494`	`}`
`1484`		`- // For noscript we want it to be a Resource so we can avoid rendering children.`
`1485`		`- // In the future we should move this warning to the server and handle it`
`1486`		`- // separately on the client`
`1487`		`- return type === 'noscript';`
	`1495`	`+ return false;`
`1488`	`1496`	`}`
`1489`	`1497`	`}`
`1490`	`1498`	`return false;`