Revert using 3 seconds poll on Windows

from listSerialsj library 1.0.8 the serial polling is executed using the listComPorts method (which is much more cpu intensive than the previous one) to avoid bug arduino#4700. The 3 second poll rate is needed to avoid cpu hogging

Author: facchinm

arduino-core/src/cc/arduino/packages/discoverers/serial/SerialBoardsLister.java

@@ -38,6 +38,8 @@
 
 import java.util.*;
 
+import static processing.app.helpers.OSUtils.isWindows;
+
 public class SerialBoardsLister extends TimerTask {
 
   private final SerialDiscovery serialDiscovery;
@@ -52,17 +54,15 @@ public SerialBoardsLister(SerialDiscovery serialDiscovery) {
   }
 
   public void start(Timer timer) {
-    timer.schedule(this, 0, 1000);
+
+    if (isWindows()) {
+      timer.schedule(this, 0, 3000);
+    } else {
+      timer.schedule(this, 0, 1000);
+    }
   }
 
   public synchronized void retriggerDiscovery(boolean polled) {
-    while (BaseNoGui.packages == null) {
-      try {
-        Thread.sleep(1000);
-      } catch (InterruptedException e) {
-        // noop
-      }
-    }
     Platform platform = BaseNoGui.getPlatform();
     if (platform == null) {
       return;
@@ -103,6 +103,11 @@ public synchronized void retriggerDiscovery(boolean polled) {
       String[] parts = newPort.split("_");
       String port = parts[0];
 
+      if (parts.length != 3) {
+        // something went horribly wrong
+        continue;
+      }
+
       Map<String, Object> boardData = platform.resolveDeviceByVendorIdProductId(port, BaseNoGui.packages);
 
       BoardPort boardPort = null;
@@ -168,6 +173,9 @@ public synchronized void retriggerDiscovery(boolean polled) {
 
   @Override
   public void run() {
+     if (BaseNoGui.packages == null) {
+        return;
+     }
      retriggerDiscovery(true);
   }
 }