From 2275f42c28b2e3a3e3a1cd63eb7b75779054a7a6 Mon Sep 17 00:00:00 2001 From: Peter Tseng Date: Mon, 4 Dec 2017 06:49:58 -0800 Subject: [PATCH] remove `use std::ascii::AsciiExt` for rust 1.23 In rust 1.23, the `AsciiExt` methods are implemented directly on the concerned types, so attempting to import `AsciiExt` results in an unused import. Rust language PR: https://github.com/rust-lang/rust/pull/44042 PSA: https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726 This started warning as an unused import on nightly sometime between 2017-11-02 and 2017-11-09: https://travis-ci.org/exercism/rust/builds/296391447 https://travis-ci.org/exercism/rust/builds/299770403 This started warning on beta exactly when 1.23.0 became Beta (it was accepted on 1.22.0): https://travis-ci.org/exercism/rust/builds/303139434 https://travis-ci.org/exercism/rust/builds/306431846 As 1.23 is now stable and our repo disallows warnings on stable, we will need this. --- exercises/atbash-cipher/example.rs | 2 -- exercises/crypto-square/example.rs | 2 -- exercises/etl/example.rs | 1 - exercises/forth/example.rs | 1 - exercises/pangram/example.rs | 1 - 5 files changed, 7 deletions(-) diff --git a/exercises/atbash-cipher/example.rs b/exercises/atbash-cipher/example.rs index 8d06f8120..97de6d80b 100644 --- a/exercises/atbash-cipher/example.rs +++ b/exercises/atbash-cipher/example.rs @@ -1,5 +1,3 @@ -use std::ascii::AsciiExt; - fn ascii(ch: char) -> u8 { ch as u8 } diff --git a/exercises/crypto-square/example.rs b/exercises/crypto-square/example.rs index d0dff7426..04ad395c9 100644 --- a/exercises/crypto-square/example.rs +++ b/exercises/crypto-square/example.rs @@ -1,5 +1,3 @@ -use std::ascii::AsciiExt; - extern crate itertools; use itertools::Itertools; diff --git a/exercises/etl/example.rs b/exercises/etl/example.rs index 011af4963..187bcc5bf 100644 --- a/exercises/etl/example.rs +++ b/exercises/etl/example.rs @@ -1,4 +1,3 @@ -use std::ascii::AsciiExt; use std::collections::BTreeMap; pub fn transform(input: &BTreeMap>) -> BTreeMap { diff --git a/exercises/forth/example.rs b/exercises/forth/example.rs index ab7eacaf7..d02882dc7 100644 --- a/exercises/forth/example.rs +++ b/exercises/forth/example.rs @@ -1,4 +1,3 @@ -use std::ascii::AsciiExt; use std::collections::HashMap; use std::collections::LinkedList; use std::str::FromStr; diff --git a/exercises/pangram/example.rs b/exercises/pangram/example.rs index 585d178d8..c338ffa6f 100644 --- a/exercises/pangram/example.rs +++ b/exercises/pangram/example.rs @@ -1,5 +1,4 @@ use std::collections::BTreeSet; -use std::ascii::AsciiExt; use std::iter::FromIterator; pub fn is_pangram(sentence: &str) -> bool {