Skip to content

Commit 1dbd204

Browse files
matthew-carrollmatthew-carroll
authored
Moved io.flutter.embedding.engine.android package to io.flutter.embedding.android (flutter#8221)
1 parent bb35436 commit 1dbd204

File tree

12 files changed

+29
-35
lines changed

12 files changed

+29
-35
lines changed

‎ci/licenses_golden/licenses_flutter

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -467,16 +467,16 @@ FILE: ../../../flutter/shell/platform/android/io/flutter/app/FlutterActivityEven
467467
FILE: ../../../flutter/shell/platform/android/io/flutter/app/FlutterApplication.java
468468
FILE: ../../../flutter/shell/platform/android/io/flutter/app/FlutterFragmentActivity.java
469469
FILE: ../../../flutter/shell/platform/android/io/flutter/app/FlutterPluginRegistry.java
470+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidKeyProcessor.java
471+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java
472+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
473+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragment.java
474+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterSurfaceView.java
475+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterTextureView.java
476+
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java
470477
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java
471478
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java
472479
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterShellArgs.java
473-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/AndroidKeyProcessor.java
474-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/AndroidTouchProcessor.java
475-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterActivity.java
476-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java
477-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterSurfaceView.java
478-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterTextureView.java
479-
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java
480480
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartExecutor.java
481481
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartMessenger.java
482482
FILE: ../../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/PlatformMessageHandler.java

‎shell/platform/android/BUILD.gn

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,16 @@ java_library("flutter_shell_java") {
109109
"io/flutter/app/FlutterApplication.java",
110110
"io/flutter/app/FlutterFragmentActivity.java",
111111
"io/flutter/app/FlutterPluginRegistry.java",
112+
"io/flutter/embedding/android/AndroidKeyProcessor.java",
113+
"io/flutter/embedding/android/AndroidTouchProcessor.java",
114+
"io/flutter/embedding/android/FlutterActivity.java",
115+
"io/flutter/embedding/android/FlutterFragment.java",
116+
"io/flutter/embedding/android/FlutterSurfaceView.java",
117+
"io/flutter/embedding/android/FlutterTextureView.java",
118+
"io/flutter/embedding/android/FlutterView.java",
112119
"io/flutter/embedding/engine/FlutterEngine.java",
113120
"io/flutter/embedding/engine/FlutterJNI.java",
114121
"io/flutter/embedding/engine/FlutterShellArgs.java",
115-
"io/flutter/embedding/engine/android/AndroidKeyProcessor.java",
116-
"io/flutter/embedding/engine/android/AndroidTouchProcessor.java",
117-
"io/flutter/embedding/engine/android/FlutterActivity.java",
118-
"io/flutter/embedding/engine/android/FlutterFragment.java",
119-
"io/flutter/embedding/engine/android/FlutterSurfaceView.java",
120-
"io/flutter/embedding/engine/android/FlutterTextureView.java",
121-
"io/flutter/embedding/engine/android/FlutterView.java",
122122
"io/flutter/embedding/engine/dart/DartExecutor.java",
123123
"io/flutter/embedding/engine/dart/DartMessenger.java",
124124
"io/flutter/embedding/engine/dart/PlatformMessageHandler.java",

‎shell/platform/android/io/flutter/embedding/engine/android/AndroidKeyProcessor.java renamed to ‎shell/platform/android/io/flutter/embedding/android/AndroidKeyProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.support.annotation.NonNull;
88
import android.support.annotation.Nullable;

‎shell/platform/android/io/flutter/embedding/engine/android/AndroidTouchProcessor.java renamed to ‎shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.flutter.embedding.engine.android;
1+
package io.flutter.embedding.android;
22

33
import android.os.Build;
44
import android.support.annotation.IntDef;
@@ -164,7 +164,9 @@ public boolean onGenericMotionEvent(MotionEvent event) {
164164

165165
// ACTION_HOVER_MOVE always applies to a single pointer only.
166166
addPointerForIndex(event, event.getActionIndex(), pointerChange, 0, packet);
167-
assert(packet.position() % (POINTER_DATA_FIELD_COUNT * BYTES_PER_FIELD) != 0);
167+
if (packet.position() % (POINTER_DATA_FIELD_COUNT * BYTES_PER_FIELD) != 0) {
168+
throw new AssertionError("Packet position is not on field boundary.");
169+
}
168170
renderer.dispatchPointerDataPacket(packet, packet.position());
169171
return true;
170172
}

‎shell/platform/android/io/flutter/embedding/engine/android/FlutterActivity.java renamed to ‎shell/platform/android/io/flutter/embedding/android/FlutterActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.content.Context;
88
import android.content.Intent;

‎shell/platform/android/io/flutter/embedding/engine/android/FlutterFragment.java renamed to ‎shell/platform/android/io/flutter/embedding/android/FlutterFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.content.Context;
88
import android.content.Intent;

‎shell/platform/android/io/flutter/embedding/engine/android/FlutterSurfaceView.java renamed to ‎shell/platform/android/io/flutter/embedding/android/FlutterSurfaceView.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.content.Context;
88
import android.support.annotation.NonNull;
@@ -12,8 +12,6 @@
1212
import android.view.SurfaceHolder;
1313
import android.view.SurfaceView;
1414

15-
import java.nio.ByteBuffer;
16-
1715
import io.flutter.embedding.engine.renderer.FlutterRenderer;
1816

1917
/**

‎shell/platform/android/io/flutter/embedding/engine/android/FlutterTextureView.java renamed to ‎shell/platform/android/io/flutter/embedding/android/FlutterTextureView.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.content.Context;
88
import android.graphics.SurfaceTexture;
@@ -13,8 +13,6 @@
1313
import android.view.Surface;
1414
import android.view.TextureView;
1515

16-
import java.nio.ByteBuffer;
17-
1816
import io.flutter.embedding.engine.renderer.FlutterRenderer;
1917

2018
/**

‎shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java renamed to ‎shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
package io.flutter.embedding.engine.android;
5+
package io.flutter.embedding.android;
66

77
import android.annotation.TargetApi;
88
import android.content.Context;
99
import android.content.res.Configuration;
1010
import android.graphics.Rect;
1111
import android.os.Build;
1212
import android.os.LocaleList;
13-
import android.provider.Settings;
1413
import android.support.annotation.NonNull;
1514
import android.support.annotation.Nullable;
1615
import android.support.annotation.RequiresApi;
@@ -20,7 +19,6 @@
2019
import android.view.KeyEvent;
2120
import android.view.MotionEvent;
2221
import android.view.WindowInsets;
23-
import android.view.WindowManager;
2422
import android.view.accessibility.AccessibilityManager;
2523
import android.view.accessibility.AccessibilityNodeProvider;
2624
import android.view.inputmethod.EditorInfo;
@@ -33,10 +31,8 @@
3331

3432
import io.flutter.embedding.engine.FlutterEngine;
3533
import io.flutter.embedding.engine.renderer.FlutterRenderer;
36-
import io.flutter.embedding.engine.systemchannels.AccessibilityChannel;
3734
import io.flutter.plugin.editing.TextInputPlugin;
3835
import io.flutter.view.AccessibilityBridge;
39-
import io.flutter.view.VsyncWaiter;
4036

4137
/**
4238
* Displays a Flutter UI on an Android device.

‎shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import java.nio.ByteBuffer;
1616
import java.util.concurrent.atomic.AtomicLong;
1717

18+
import io.flutter.embedding.android.FlutterView;
1819
import io.flutter.embedding.engine.FlutterJNI;
1920
import io.flutter.view.TextureRegistry;
2021

@@ -29,7 +30,7 @@
2930
* code via JNI. The corresponding {@link RenderSurface} is used as a delegate to carry out
3031
* certain actions on behalf of this {@code FlutterRenderer} within an Android view hierarchy.
3132
*
32-
* {@link io.flutter.embedding.engine.android.FlutterView} is an implementation of a {@link RenderSurface}.
33+
* {@link FlutterView} is an implementation of a {@link RenderSurface}.
3334
*/
3435
@TargetApi(Build.VERSION_CODES.JELLY_BEAN)
3536
public class FlutterRenderer implements TextureRegistry {

‎shell/platform/android/io/flutter/view/FlutterView.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import android.os.Build;
1616
import android.os.Handler;
1717
import android.os.LocaleList;
18-
import android.provider.Settings;
1918
import android.support.annotation.RequiresApi;
2019
import android.text.format.DateFormat;
2120
import android.util.AttributeSet;
@@ -28,8 +27,8 @@
2827
import android.view.inputmethod.InputMethodManager;
2928
import io.flutter.app.FlutterPluginRegistry;
3029
import io.flutter.embedding.engine.FlutterJNI;
31-
import io.flutter.embedding.engine.android.AndroidKeyProcessor;
32-
import io.flutter.embedding.engine.android.AndroidTouchProcessor;
30+
import io.flutter.embedding.android.AndroidKeyProcessor;
31+
import io.flutter.embedding.android.AndroidTouchProcessor;
3332
import io.flutter.embedding.engine.dart.DartExecutor;
3433
import io.flutter.embedding.engine.renderer.FlutterRenderer;
3534
import io.flutter.embedding.engine.systemchannels.AccessibilityChannel;

‎tools/android_lint/baseline.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@
480480
errorLine1=" public boolean onTouchEvent(MotionEvent event) {"
481481
errorLine2=" ~~~~~~~~~~~~">
482482
<location
483-
file="../../../flutter/shell/platform/android/io/flutter/embedding/engine/android/FlutterView.java"
483+
file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java"
484484
line="311"
485485
column="18"/>
486486
</issue>

0 commit comments

Comments
 (0)