Skip to content

Commit 854adf6

Browse files
authored
Fix other.test_emcc_print_file_name under windows. NFC (#17261)
1 parent 1706b8e commit 854adf6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,7 @@ jobs:
508508
other.test_embed_file_dup
509509
other.test_dot_a_all_contents_invalid
510510
other.test_emcc_print_search_dirs
511+
other.test_emcc_print_file_name
511512
other.test_pkg_config*"
512513
# Run a single websockify-based test to ensure it works on windows.
513514
- run-tests:

tests/test_other.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,8 @@ def test_emcc_print_search_dirs(self):
626626
def test_emcc_print_file_name(self):
627627
self.run_process([EMBUILDER, 'build', 'libc'])
628628
output = self.run_process([EMCC, '-print-file-name=libc.a'], stdout=PIPE).stdout
629-
self.assertContained(shared.Cache.get_lib_name('libc.a'), output)
629+
filename = Path(output)
630+
self.assertContained(shared.Cache.get_lib_name('libc.a'), str(filename))
630631

631632
def test_emar_em_config_flag(self):
632633
# Test that the --em-config flag is accepted but not passed down do llvm-ar.

0 commit comments

Comments
 (0)