Skip to content

Commit e28a1b6

Browse files
committed
Rollup merge of rust-lang#32271 - frewsxcv:compiletest-ignored-help-note, r=nikomatsakis
Add comment about opt-in nature of compiletest note/help messages. The opt-in functionality was proposed and discussed in rust-lang#21195
2 parents 8be1d7d + 6ed7846 commit e28a1b6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/compiletest/runtest.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,6 +1025,10 @@ fn check_expected_errors(revision: Option<&str>,
10251025
expected.replace(r"\", "/")
10261026
}).collect::<Vec<String>>();
10271027

1028+
// If the testcase being checked contains at least one expected "help"
1029+
// message, then we'll ensure that all "help" messages are expected.
1030+
// Otherwise, all "help" messages reported by the compiler will be ignored.
1031+
// This logic also applies to "note" messages.
10281032
let (expect_help, expect_note) =
10291033
expected_errors.iter()
10301034
.fold((false, false),

0 commit comments

Comments
 (0)