Skip to content

Remove xUnit from source-build-externals #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mthalman opened this issue Apr 17, 2025 · 1 comment · May be fixed by dotnet/source-build-externals#472
Open

Remove xUnit from source-build-externals #5059

mthalman opened this issue Apr 17, 2025 · 1 comment · May be fixed by dotnet/source-build-externals#472
Assignees
@MichaelSimons
Labels
area-SBE Source build externals

Comments

@mthalman
Copy link
Member

The only dependency on xUnit from a source build perspective was the scenario-tests repo. With the changes in dotnet/sdk#48327, the scenario-tests repo can be built in an isolated manner with no dependency on source-build-externals. Therefore, the xunit submodule can be removed from source-build-externals.
@MichaelSimons MichaelSimons linked a pull request Apr 21, 2025 that will close this issue
Draft
@MichaelSimons MichaelSimons self-assigned this Apr 21, 2025
@MichaelSimons MichaelSimons moved this from Backlog to In Progress in .NET Source Build Apr 21, 2025
@MichaelSimons MichaelSimons moved this from In Progress to Blocked in .NET Source Build Apr 22, 2025
@MichaelSimons MichaelSimons added area-SBE Source build externals and removed untriaged labels Apr 24, 2025
@MichaelSimons
Copy link
Member

This is blocked on #5061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-SBE Source build externals
Projects
.NET Source Build
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove xunit MichaelSimons/source-build-externals
2 participants
@MichaelSimons @mthalman