Skip to content

Commit 1e26857

Browse files
authored
Don't exclude System.IO.Pipelines from TargetingPack version check (#39287)
1 parent 4881b1d commit 1e26857

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

src/Framework/test/TargetingPackTests.cs

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -104,22 +104,17 @@ public void RefAssemblyReferencesHaveExpectedAssemblyVersions()
104104

105105
Assert.All(dlls, path =>
106106
{
107-
// Skip netstandard2.0 System.IO.Pipelines assembly. References have old versions.
108-
var filename = Path.GetFileName(path);
109-
if (!string.Equals("System.IO.Pipelines.dll", filename, StringComparison.OrdinalIgnoreCase))
110-
{
111-
using var fileStream = File.OpenRead(path);
112-
using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
113-
var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
107+
using var fileStream = File.OpenRead(path);
108+
using var peReader = new PEReader(fileStream, PEStreamOptions.Default);
109+
var reader = peReader.GetMetadataReader(MetadataReaderOptions.Default);
114110

115-
Assert.All(reader.AssemblyReferences, handle =>
116-
{
117-
var reference = reader.GetAssemblyReference(handle);
118-
var result = 0 == reference.Version.Revision;
111+
Assert.All(reader.AssemblyReferences, handle =>
112+
{
113+
var reference = reader.GetAssemblyReference(handle);
114+
var result = (0 == reference.Version.Revision && 0 == reference.Version.Build);
119115

120-
Assert.True(result, $"In {filename}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
121-
});
122-
}
116+
Assert.True(result, $"In {Path.GetFileName(path)}, {reference.GetAssemblyName()} has unexpected version {reference.Version}.");
117+
});
123118
});
124119
}
125120

0 commit comments

Comments
 (0)