Skip to content

Not playable video after setting width #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
GABAnich opened this issue Apr 16, 2021 · 3 comments · Fixed by #1559
Closed
1 task done

Not playable video after setting width #1558

GABAnich opened this issue Apr 16, 2021 · 3 comments · Fixed by #1559
Labels
docs related to the documentation of docsify itself

Comments

@GABAnich
Copy link

Bug Report

[Example](_media/actions_example.mp4 ':include :type=video width=100%')

image

Steps to reproduce

[Example](_media/actions_example.mp4 ':include :type=video width=100%')

What is current behaviour

The video is not playable

What is the expected behavior

The video should be playable with width 100%

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Ubuntu 18.04.5 LTS (Bionic Beaver)

  • Node.js version: v12.13.1

  • npm/yarn version: yarn -v: 1.22.5

  • Browser version: Google Chrome Version 89.0.4389.82 (Official Build) (64-bit)

  • Docsify version: 4.4.3

  • Docsify plugins: <script src="//cdn.jsdelivr.net/npm/[email protected]/components/prism-graphql.min.js"></script>

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@GABAnich
Copy link
Author

Seems once we setup video attributes like width default attribute controls disappears

It works with these code:

[Example](_media/actions_example.mp4 ':include :type=video width=100% controls')

@GABAnich
Copy link
Author

Take look at

html: `<video src="${url}" ${title || 'controls'}>Not Support</video>`,

Once any attribute is set, controls will be replaced

@Koooooo-7 Koooooo-7 added bug confirmed as a bug enhancement and removed bug confirmed as a bug labels Apr 18, 2021
@Koooooo-7
Copy link
Member

Koooooo-7 commented Apr 18, 2021

thx for ur report ! it seems should be refine.
when the title is not empty, the controls would be removed.
you can use the

[Example](_media/actions_example.mp4 ':include :type=video controls width=100%')

to add the controls manually for now.

@Koooooo-7 Koooooo-7 added docs related to the documentation of docsify itself and removed enhancement labels Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs related to the documentation of docsify itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants