Skip to content

regression: hamburger menu icon not visible on mobile until after scrolling a little #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
trusktr opened this issue Jun 15, 2020 · 4 comments
Closed
1 task
Labels
bug confirmed as a bug regression

Comments

@trusktr
Copy link
Member

trusktr commented Jun 15, 2020

Bug Report

Regression: the mobile menu is out of view by default now

Steps to reproduce

Visit a docsify site on mobile.

What is current behaviour

On the latest vercel preview that I grabbed from #1215, https://docsify-preview-p88m1zgcc.vercel.app, I am not able to see the hamburger menu on mobile unless I scroll:

menu-hidden

What is the expected behaviour

The menu should be visible I think, like it is on docsify.js.org currently.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: develop

  • Docsify plugins:

@trusktr trusktr added bug confirmed as a bug regression labels Jun 15, 2020
@mohammedsahl
Copy link
Contributor

Is this still an issue after #1215? We decided not to translate the cover page hence zoom should be disabled. If required I can work on copying the current "sidebar and content" behavior onto the coverpage such that nothing is rendered beyond the viewport
@trusktr

@trusktr
Copy link
Member Author

trusktr commented Jun 19, 2020

I believe this is a different issue: at the bottom left corner, the hamburger menu icon isn't visible until I scroll the page up.

@trusktr trusktr changed the title regression: menu not visible on mobile until after scrolling a little regression: hamburger menu icon not visible on mobile until after scrolling a little Jun 19, 2020
@jhildenbiddle
Copy link
Member

@trusktr --

I'm not seeing this behavior on docsify.js.org on an iPhone, Chrome Dev Tools, or Safari's Responsive Design Mode. Can you verify if this is still an issue?

@paulhibbitts
Copy link
Collaborator

Re-tested with Android Phone, iPhone, and Safari Responsive Design Mode, so closing issue - please feel free to re-open if issue is still seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug regression
Projects
None yet
Development

No branches or pull requests

4 participants