Skip to content

Server Side Rendering appears to no longer work #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
tobyhede opened this issue Apr 2, 2020 · 5 comments
Closed
1 task done

Server Side Rendering appears to no longer work #1101

tobyhede opened this issue Apr 2, 2020 · 5 comments
Labels
bug confirmed as a bug pinned This is to pinned the PR/Issue in order to keep it open

Comments

@tobyhede
Copy link

tobyhede commented Apr 2, 2020

Bug Report

Steps to reproduce

Follow the instructions on Server Side Rendering
https://docsify.js.org/#/ssr

What is current behaviour

Following the SSR instructions results in a blank page.
It looks like the app and config are not being injected by the server.

Using the package.json configuration, I can get docsify start to run.
It looks like there is also a bug in docsify-cli when using the config file -c option .

What is the expected behaviour

The content should be rendered into the appropriate areas in the HTML template marked by comments.

  <!--inject-app-->
  <!--inject-config-->    

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: OSX

  • Node.js version: v12.13.1

  • npm/yarn version: 6.12.1

  • Browser version: Latest Chrome and Firefox

  • Docsify version: [email protected], [email protected]

  • Docsify plugins: None, default install

@anikethsaha
Copy link
Member

can you share a reproducible repo ?

@tobyhede
Copy link
Author

tobyhede commented Apr 2, 2020

Sandbox is here - https://codesandbox.io/s/github/tobyhede/docsify-ssr

docsify start . -c ssr.config.js has an error.

SSR Docs says "You can configure it in a special config file, or package.json."
So I used docsify start with package.json.

But the injection doesn't happen.

@stale
Copy link

stale bot commented Jun 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 1, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open bug confirmed as a bug and removed wontfix labels Jun 1, 2020
@mattvb91
Copy link

Experiencing the same issue currently in particular with this #704

@paulhibbitts
Copy link
Collaborator

Previous SSR code removed for upcoming v5 release, so closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug pinned This is to pinned the PR/Issue in order to keep it open
Projects
None yet
Development

No branches or pull requests

4 participants