Skip to content

Commit af9d384

Browse files
Haibo Lismb49
Haibo Li
authored andcommitted
kasan: print the original fault addr when access invalid shadow
BugLink: https://bugs.launchpad.net/bugs/2049417 commit babddbf upstream. when the checked address is illegal,the corresponding shadow address from kasan_mem_to_shadow may have no mapping in mmu table. Access such shadow address causes kernel oops. Here is a sample about oops on arm64(VA 39bit) with KASAN_SW_TAGS and KASAN_OUTLINE on: [ffffffb80aaaaaaa] pgd=000000005d3ce003, p4d=000000005d3ce003, pud=000000005d3ce003, pmd=0000000000000000 Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP Modules linked in: CPU: 3 PID: 100 Comm: sh Not tainted 6.6.0-rc1-dirty #43 Hardware name: linux,dummy-virt (DT) pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __hwasan_load8_noabort+0x5c/0x90 lr : do_ib_ob+0xf4/0x110 ffffffb80aaaaaaa is the shadow address for efffff80aaaaaaaa. The problem is reading invalid shadow in kasan_check_range. The generic kasan also has similar oops. It only reports the shadow address which causes oops but not the original address. Commit 2f004ee("x86/kasan: Print original address on #GP") introduce to kasan_non_canonical_hook but limit it to KASAN_INLINE. This patch extends it to KASAN_OUTLINE mode. Link: https://lkml.kernel.org/r/[email protected] Fixes: 2f004ee("x86/kasan: Print original address on #GP") Signed-off-by: Haibo Li <[email protected]> Reviewed-by: Andrey Konovalov <[email protected]> Cc: Alexander Potapenko <[email protected]> Cc: Andrey Ryabinin <[email protected]> Cc: AngeloGioacchino Del Regno <[email protected]> Cc: Dmitry Vyukov <[email protected]> Cc: Haibo Li <[email protected]> Cc: Matthias Brugger <[email protected]> Cc: Vincenzo Frascino <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Kees Cook <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Roxana Nicolescu <[email protected]> Signed-off-by: Stefan Bader <[email protected]>
1 parent 6d745da commit af9d384

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

include/linux/kasan.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,10 @@ static inline void kasan_free_shadow(const struct vm_struct *vm) {}
471471

472472
#endif /* (CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS) && !CONFIG_KASAN_VMALLOC */
473473

474-
#ifdef CONFIG_KASAN_INLINE
474+
#ifdef CONFIG_KASAN
475475
void kasan_non_canonical_hook(unsigned long addr);
476-
#else /* CONFIG_KASAN_INLINE */
476+
#else /* CONFIG_KASAN */
477477
static inline void kasan_non_canonical_hook(unsigned long addr) { }
478-
#endif /* CONFIG_KASAN_INLINE */
478+
#endif /* CONFIG_KASAN */
479479

480480
#endif /* LINUX_KASAN_H */

mm/kasan/report.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,9 +457,8 @@ bool kasan_report(unsigned long addr, size_t size, bool is_write,
457457
return ret;
458458
}
459459

460-
#ifdef CONFIG_KASAN_INLINE
461460
/*
462-
* With CONFIG_KASAN_INLINE, accesses to bogus pointers (outside the high
461+
* With CONFIG_KASAN, accesses to bogus pointers (outside the high
463462
* canonical half of the address space) cause out-of-bounds shadow memory reads
464463
* before the actual access. For addresses in the low canonical half of the
465464
* address space, as well as most non-canonical addresses, that out-of-bounds
@@ -495,4 +494,3 @@ void kasan_non_canonical_hook(unsigned long addr)
495494
pr_alert("KASAN: %s in range [0x%016lx-0x%016lx]\n", bug_type,
496495
orig_addr, orig_addr + KASAN_GRANULE_SIZE - 1);
497496
}
498-
#endif

0 commit comments

Comments
 (0)