Skip to content

Rails 7.0.0 #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhenrixon opened this issue Dec 10, 2021 · 8 comments
Closed

Rails 7.0.0 #910

mhenrixon opened this issue Dec 10, 2021 · 8 comments
Assignees
Milestone

Comments

@mhenrixon
Copy link

To be able to use annoate with rails 7, the dependency needs to be loosened up. It currently works with rails 7.0.0.rc1.

I have been using annotate with rails 7 alpha and now rc but I suspect that will break as rails 7 goes live because of < 7.0 in gemspec on active record.

Version

  • annotate 3.1.1
  • rails 7.0.0
  • ruby 3.0.3
@kurt-mueller-osumc
Copy link

Yep, same :D. Annotate was working fine with the Rails 7 release candidates.

@ryanb
Copy link

ryanb commented Dec 17, 2021

You may want to use dabit's fork from PR #912 until this is resolved.

git_source(:github) { |repo| "https://github.com/#{repo}.git" }
# ...
gem 'annotate', github: 'dabit/annotate_models', branch: 'rails-7'

@addisonmartin
Copy link

Can we please get a new release with the Active Record (Rails) version relaxed? It seems like its working fine with Rails 7.

@kapso
Copy link

kapso commented Jan 12, 2022

Any chance of a new release? Thanks.

@ctran ctran self-assigned this Jan 31, 2022
@FlorianBruniaux
Copy link

@ctran Thank you for responding to my call for help on linkedin! You rock!

@ctran ctran modified the milestones: v4.0.0, v3.2.0 Jan 31, 2022
@ctran
Copy link
Owner

ctran commented Feb 3, 2022

This is merged in #912

@ctran ctran closed this as completed Feb 3, 2022
@kapso
Copy link

kapso commented Feb 7, 2022

@ctran any plans of releasing this?

@ctran
Copy link
Owner

ctran commented Feb 8, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants