Skip to content

annotate 2.7.2 adds trailing space to the last line of route map #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
monad-san opened this issue Jun 5, 2017 · 1 comment · Fixed by #483
Closed

annotate 2.7.2 adds trailing space to the last line of route map #474

monad-san opened this issue Jun 5, 2017 · 1 comment · Fixed by #483
Labels
Milestone

Comments

@monad-san
Copy link

After updating annotate gem to 2.7.2, when I run annotate --routes in rails project, it adds a trailing space to the last line of config/routes.rb route map.

expected result (< 2.7.1):

# == Route Map
#
#                   Prefix Verb   URI Pattern                                 Controller#Action
#                     root GET    /                                           hoge#index
(... routes lines ...)
#[EOL]

actual result (2.7.2):

# == Route Map
#
#                   Prefix Verb   URI Pattern                                 Controller#Action
#                     root GET    /                                           hoge#index
(... routes lines ...)
# [EOL]

Rubocop (Layout/TrailingWhitespace) detects it as offense.

@ctran ctran added this to the v2.7.3 milestone Jun 6, 2017
@ctran ctran added the bug label Jun 6, 2017
@ctran
Copy link
Owner

ctran commented Jun 6, 2017

How did that happen? I thought we had unit tests? Wait...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants