Support clang tools version 16 (#45)

* feat: support clang-tools version 16
* fix: test workflow and README.md

Author: shenxianpeng

.github/workflows/python-test.yml

@@ -52,7 +52,7 @@ jobs:
     needs: [build]
     strategy:
       matrix:
-        version: [ 3.9, 4, 5, 6, 7, 8, 9, 10, 11, 12, 12.0.1, 13, 14, 15 ]
+        version: [ 3.9, 4, 5, 6, 7, 8, 9, 10, 11, 12, 12.0.1, 13, 14, 15, 16 ]
         os: [ ubuntu-latest, macos-latest, windows-latest ]
       fail-fast: false
     runs-on: ${{ matrix.os }}
@@ -110,11 +110,14 @@ jobs:
             clang-tidy-12 --version
           else
             clang-format-${{ matrix.version }} --version
-            if [ "${{ matrix.version }}" = "14" -o "${{ matrix.version }}" = "15" ]; then
-              echo "skip version ${{ matrix.version }} because Segmentation fault on ubuntu."
-            else
-              clang-tidy-${{ matrix.version }} --version
-            fi
+            case "${{ matrix.version }}" in
+              14|15|16)
+                echo "Skipping version ${{ matrix.version }} due to Segmentation fault on Ubuntu."
+                ;;
+              *)
+                clang-tidy-${{ matrix.version }} --version
+                ;;
+            esac
           fi
 
   docs:

README.rst

@@ -124,27 +124,27 @@ Supported versions
 clang-format
 ************
 .. csv-table::
-    :header: "Version", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
+    :header: "Version", "16", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
     :stub-columns: 1
 
-    Linux,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Linux,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
 
 clang-tidy
 **********
 .. csv-table::
-    :header: "Version", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
+    :header: "Version", "16", "15", "14", "13", "12", "11", "10", "9", "8", "7", "6", "5", "4", "3.9"
     :stub-columns: 1
 
-    Linux,❌,❌,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
-    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Linux,❌,❌,❌,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    Windows,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
+    macOS,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️,✔️
 
 Know issues:
 
-1. clang-tidy-14 and clang-tidy-15 has Segmentation fault on Ubuntu 22.02.
-2. clang-tidy-14 and clang-tidy-15 is over 1 GB for MacOSX
+1. clang-tidy-14, clang-tidy-15 and clang-tidy-16 has Segmentation fault on Ubuntu 22.02.
+2. clang-tidy-14, clang-tidy-15 and clang-tidy-16 is over 1 GB for MacOSX
 
 Thanks to the project
 `clang-tools-static-binaries <https://github.com/muttleyxd/clang-tools-static-binaries>`_

clang_tools/install.py

@@ -63,7 +63,7 @@ def is_installed(tool_name: str, version: str) -> Optional[Path]:
 
 
 def clang_tools_binary_url(
-    tool: str, version: str, release_tag: str = "master-1d7ec53d"
+    tool: str, version: str, release_tag: str = "master-9ba48406"
 ) -> str:
     """Assemble the URL to the binary.
 

tests/test_install.py

@@ -13,7 +13,7 @@
 )
 
 
-@pytest.mark.parametrize("version", [str(v) for v in range(7, 14)] + ["12.0.1"])
+@pytest.mark.parametrize("version", [str(v) for v in range(7, 17)] + ["12.0.1"])
 @pytest.mark.parametrize("tool_name", ["clang-format", "clang-tidy"])
 def test_clang_tools_binary_url(tool_name: str, version: str):
     """Test `clang_tools_binary_url()`"""
@@ -50,7 +50,7 @@ def test_create_symlink(monkeypatch: pytest.MonkeyPatch, tmp_path: Path):
     assert not create_sym_link(tool_name, version, str(tmp_path), True)
 
 
-@pytest.mark.parametrize("version", [str(v) for v in range(10, 14)] + ["12.0.1"])
+@pytest.mark.parametrize("version", [str(v) for v in range(10, 17)] + ["12.0.1"])
 def test_install_tools(monkeypatch: pytest.MonkeyPatch, tmp_path: Path, version: str):
     """Test install tools to a temp directory."""
     monkeypatch.chdir(tmp_path)

tests/test_main.py

@@ -23,7 +23,7 @@ def parser() -> ArgumentParser:
 
 
 @pytest.mark.parametrize("arg_name", ["install", "directory", "uninstall"])
-@pytest.mark.parametrize("arg_value", [str(v) for v in range(7, 14)] + ["12.0.1"])
+@pytest.mark.parametrize("arg_value", [str(v) for v in range(7, 17)] + ["12.0.1"])
 def test_arg_parser(arg_name: str, arg_value: str, parser: ArgumentParser):
     """Test CLI arg parsing using a set of fake args."""
     args = parser.parse_args([f"--{arg_name}={arg_value}"])

tests/test_util.py

@@ -13,7 +13,7 @@ def test_check_install_os():
 
 
 @pytest.mark.parametrize(
-    "tag", ["master-1d7ec53d", pytest.param("latest", marks=pytest.mark.xfail)]
+    "tag", ["master-9ba48406", pytest.param("latest", marks=pytest.mark.xfail)]
 )
 def test_download_file(monkeypatch: pytest.MonkeyPatch, tmp_path: Path, tag: str):
     """Test that deliberately fails to download a file."""
@@ -30,5 +30,5 @@ def test_get_sha(monkeypatch: pytest.MonkeyPatch):
     expected = Path(f"clang-query-12_{install_os}-amd64.sha512sum").read_text(
         encoding="utf-8"
     )
-    url = clang_tools_binary_url("clang-query", "12", release_tag="master-1d7ec53d")
+    url = clang_tools_binary_url("clang-query", "12", release_tag="master-9ba48406")
     assert get_sha_checksum(url) == expected