upgrade PHPStan

Author: petrparolek

Makefile

@@ -16,7 +16,7 @@ csf:
 	vendor/bin/codefixer src tests
 
 phpstan:
-	vendor/bin/phpstan analyse -l max -c phpstan.neon src
+	vendor/bin/phpstan analyse -l 8 -c phpstan.neon src
 
 tests:
 	vendor/bin/codecept build

composer.json

@@ -32,10 +32,10 @@
     "nette/application": "^3.0",
     "nette/caching": "~2.5.8 || ^3.0",
     "ninjify/qa": "^0.12",
-    "phpstan/phpstan": "^0.12",
-    "phpstan/phpstan-deprecation-rules": "^0.12",
-    "phpstan/phpstan-nette": "^0.12",
-    "phpstan/phpstan-strict-rules": "^0.12",
+    "phpstan/phpstan": "^1.0",
+    "phpstan/phpstan-deprecation-rules": "^1.0",
+    "phpstan/phpstan-nette": "^1.0",
+    "phpstan/phpstan-strict-rules": "^1.0",
     "tracy/tracy": "~2.6.1 || ~2.7.0"
   },
   "conflict": {

phpstan.neon

@@ -6,13 +6,15 @@ includes:
 	- extension.neon
 
 parameters:
-	excludes_analyse:
+	excludePaths:
 		- %currentWorkingDirectory%/tests/_*
 
 	ignoreErrors:
 		- '#^Only booleans are allowed in a negated boolean, string\|null given.#'
 		- '#(.+)should be contravariant(.+)#'
 
+		- '#^Property Contributte\\Codeception\\Module\\NetteApplicationModule::\$path is never read, only written.#'
+
 		# Should not happen
 		- '#^Method Contributte\\Codeception\\Module\\NetteDIModule::getContainer\(\) should return Nette\\DI\\Container but returns Nette\\DI\\Container\|null#'
 		- '#^Method Contributte\\Codeception\\Http\\Request::getFile\(\) should return Nette\\Http\\FileUpload\|null but returns array\|Nette\\Http\\FileUpload\|null.#'
@@ -28,3 +30,4 @@ parameters:
 		Codeception\Module:
 			- fail
 
+	reportMaybesInPropertyPhpDocTypes: false

src/Module/NetteDIModule.php

@@ -111,6 +111,7 @@ public function getContainer(): Container
 	public function grabService(string $service)
 	{
 		try {
+			/** @phpstan-var class-string $service */
 			return $this->getContainer()->getByType($service);
 		} catch (MissingServiceException $e) {
 			$this->fail($e->getMessage());

src/Qa/PhpStan/NetteDIModuleType.php

@@ -31,7 +31,7 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
 			return $methodReflection->getReturnType();
 		}
 
-		$arg = $methodCall->args[0]->value;
+		$arg = $methodCall->getArgs()[0]->value;
 
 		if (!$arg instanceof ClassConstFetch) {
 			return $methodReflection->getReturnType();