Skip to content

Commit a6afc15

Browse files
committed
fix unit tests
1 parent 7c712c8 commit a6afc15

File tree

4 files changed

+20
-9
lines changed

4 files changed

+20
-9
lines changed

src/code42cli/config.py

+1
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ def _create_profile_section(self, name):
145145
self.parser[name][self.USERNAME_KEY] = self.DEFAULT_VALUE
146146
self.parser[name][self.IGNORE_SSL_ERRORS_KEY] = str(False)
147147
self.parser[name][self.USE_V2_FILE_EVENTS_KEY] = str(False)
148+
self.parser[name][self.API_CLIENT_AUTH_KEY] = str(False)
148149

149150
def _save(self):
150151
with open(self.path, "w+", encoding="utf-8") as file:

src/code42cli/profile.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def use_v2_file_events(self):
3535
@property
3636
def api_client_auth(self):
3737
val = self._profile.get(ConfigAccessor.API_CLIENT_AUTH_KEY)
38-
return val if val is not None else False
38+
return val if val is not None else "False"
3939

4040
@property
4141
def has_stored_password(self):

tests/conftest.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,18 @@ def alert_namespace():
8787

8888

8989
def create_profile_values_dict(
90-
authority=None, username=None, ignore_ssl=False, use_v2_file_events=False
90+
authority=None,
91+
username=None,
92+
ignore_ssl=False,
93+
use_v2_file_events=False,
94+
api_client_auth="False",
9195
):
9296
return {
9397
ConfigAccessor.AUTHORITY_KEY: "example.com",
9498
ConfigAccessor.USERNAME_KEY: "foo",
95-
ConfigAccessor.IGNORE_SSL_ERRORS_KEY: True,
96-
ConfigAccessor.USE_V2_FILE_EVENTS_KEY: False,
97-
ConfigAccessor.API_CLIENT_AUTH_KEY: False,
99+
ConfigAccessor.IGNORE_SSL_ERRORS_KEY: "True",
100+
ConfigAccessor.USE_V2_FILE_EVENTS_KEY: "False",
101+
ConfigAccessor.API_CLIENT_AUTH_KEY: "False",
98102
}
99103

100104

tests/test_config.py

+10-4
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ def test_create_profile_when_given_default_name_does_not_create(
153153
accessor = ConfigAccessor(config_parser_for_create)
154154
with pytest.raises(Exception):
155155
accessor.create_profile(
156-
ConfigAccessor.DEFAULT_VALUE, "foo", "bar", False, False
156+
ConfigAccessor.DEFAULT_VALUE, "foo", "bar", False, False, False
157157
)
158158

159159
def test_create_profile_when_no_default_profile_sets_default(
@@ -165,7 +165,9 @@ def test_create_profile_when_no_default_profile_sets_default(
165165
accessor = ConfigAccessor(config_parser_for_create)
166166
accessor.switch_default_profile = mocker.MagicMock()
167167

168-
accessor.create_profile(_TEST_PROFILE_NAME, "example.com", "bar", None, None)
168+
accessor.create_profile(
169+
_TEST_PROFILE_NAME, "example.com", "bar", None, None, None
170+
)
169171
assert accessor.switch_default_profile.call_count == 1
170172

171173
def test_create_profile_when_has_default_profile_does_not_set_default(
@@ -177,7 +179,9 @@ def test_create_profile_when_has_default_profile_does_not_set_default(
177179
accessor = ConfigAccessor(config_parser_for_create)
178180
accessor.switch_default_profile = mocker.MagicMock()
179181

180-
accessor.create_profile(_TEST_PROFILE_NAME, "example.com", "bar", None, None)
182+
accessor.create_profile(
183+
_TEST_PROFILE_NAME, "example.com", "bar", None, None, None
184+
)
181185
assert not accessor.switch_default_profile.call_count
182186

183187
def test_create_profile_when_not_existing_saves(
@@ -188,7 +192,9 @@ def test_create_profile_when_not_existing_saves(
188192
setup_parser_one_profile(mock_internal, mock_internal, config_parser_for_create)
189193
accessor = ConfigAccessor(config_parser_for_create)
190194

191-
accessor.create_profile(_TEST_PROFILE_NAME, "example.com", "bar", None, None)
195+
accessor.create_profile(
196+
_TEST_PROFILE_NAME, "example.com", "bar", None, None, None
197+
)
192198
assert mock_saver.call_count
193199

194200
def test_update_profile_when_no_profile_exists_raises_exception(

0 commit comments

Comments
 (0)