Skip to content

Fix prob_arx misalignment in this repo as well, or remove buggy vignette( section)s #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Jun 14, 2022 · 3 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation P0 high priority

Comments

@brookslogan
Copy link
Contributor

Fix cmu-delphi/epipredict#50 in this repo, or remove the buggy vignette( sections)s so they aren't copied.

@dshemetov
Copy link
Contributor

Closing as outdated.

@brookslogan
Copy link
Contributor Author

I still see prob_arx in archive.Rmd and it looks like it has the same issues; perhaps the fix is in some open PR that would move us to using arx_forecaster that attaches an appropriate target_end_date? "Appropriate" here meaning actually representing what the model is targeting.

  dat$y <- lead(y, n = ahead) # no reporting latency adjustment to make .data$version + ahead below make sense
...
      mutate(target_date = .data$version + ahead, as_of = TRUE) %>%
...
      mutate(target_date = .data$time_value + ahead, as_of = FALSE) %>%

(Also, I thought we were planning to replace these epi_slide things with epix_slide on an archive prepared with snapshot %>% mutate(version = time_value + fixed_latency) %>% as_epi_archive(), though unless fixed_latency holds true for all initial reports or we do manual latency adjustment, this means that the "appropriate" target end date labeling will show that the naive & version-aware methods are targeting different dates.)

@brookslogan brookslogan reopened this Oct 15, 2024
@brookslogan brookslogan assigned dshemetov and unassigned brookslogan Mar 11, 2025
@brookslogan
Copy link
Contributor Author

brookslogan commented Mar 11, 2025

This was already resolved here via removing this section and pointing to an epipredict vignette.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation P0 high priority
Projects
None yet
Development

No branches or pull requests

3 participants