Skip to content

Commit 6ebb904

Browse files
committed
new version passes the tests
1 parent 7d22ef8 commit 6ebb904

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

R/step_epi_slide.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ epi_slide_wrapper <- function(new_data, before, after, columns, fns, fn_names, g
211211
fn <- cols_fns[[comp_i, "fn"]][[1L]]
212212
result_name <- paste(name_prefix, fn_name, col_name, sep="_")
213213
result <- new_data %>%
214-
group_by(across(group_keys)) %>%
214+
group_by(across(all_of(group_keys))) %>%
215215
epi_slide(
216216
before = before,
217217
after = after,

tests/testthat/test-step_epi_slide.R

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,20 @@ test_that("epi_slide handles classed before/after", {
109109

110110

111111
test_that("epi_slide handles different function specs", {
112+
expect_warning(
112113
cfun <- r %>%
113114
step_epi_slide(value, .f = "mean", before = 3L) %>%
114115
prep(edf) %>%
115-
bake(new_data = NULL)
116-
ffun <- r %>%
117-
step_epi_slide(value, .f = mean, before = 3L) %>%
118-
prep(edf) %>%
119-
bake(new_data = NULL)
116+
bake(new_data = NULL),
117+
regexp = "There is an optimized version"
118+
)
119+
expect_warning(
120+
ffun <- r %>%
121+
step_epi_slide(value, .f = mean, before = 3L) %>%
122+
prep(edf) %>%
123+
bake(new_data = NULL),
124+
regexp = "There is an optimized version"
125+
)
120126
# formula NOT currently supported
121127
expect_error(
122128
lfun <- r %>%

0 commit comments

Comments
 (0)