Skip to content

Write integration tests for src/acquisition/covidcast/database.py #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
krivard opened this issue Apr 11, 2022 · 1 comment
Open
2 tasks done

Write integration tests for src/acquisition/covidcast/database.py #896

krivard opened this issue Apr 11, 2022 · 1 comment
Labels
acquisition changes acquisition logic help wanted tests integration & unit testing, bug triage and prevention v4 Big covidcast schema redesign

Comments

@krivard
Copy link
Contributor

krivard commented Apr 11, 2022

Integration tests because we do want to exercise the actual database engine here, and not a mock.

  • make sure is_latest_issue is being set correctly -
    • when adding new daily data (data in signal_load has > issue than data in signal_latest)
    • when uploading data patches (data in signal load has < issue than data in signal_latest)
  • make sure data is being correctly transferred from signal_load into signal_* and *_dim
    • make sure signal_latest is only overwritten when signal_load issue is >=
    • make sure rows are added to *_dim only when needed

+Any other corner cases that worry you.

Use integrations/acquisition/covidcast/test_*.py as templates.

@krivard krivard added the v4 Big covidcast schema redesign label Apr 11, 2022
@melange396 melange396 added acquisition changes acquisition logic tests integration & unit testing, bug triage and prevention labels Feb 3, 2023
@melange396
Copy link
Collaborator

the associated pr #925 is a good start but it will, at the very least, need to update the table names as they have changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acquisition changes acquisition logic help wanted tests integration & unit testing, bug triage and prevention v4 Big covidcast schema redesign
Projects
None yet
Development

No branches or pull requests

3 participants