Skip to content

Assess Jenkins build process for indicators and feasibility of upgrading past pip-23.0.1 #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
korlaxxalrok opened this issue Apr 19, 2023 · 0 comments
Assignees
Labels

Comments

@korlaxxalrok
Copy link
Contributor

Related to #1838

In our Jenkins build process we first upgrade to latest pip, then try to build _delphi_utils_python. We do this via a script that is called for each indicator we are building. Our builds are parallelized, so we are running this script in parallel too.

When we use pip-23.01 there is deprecation warning of:

DEPRECATION: delphi-utils is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559

Part of the new behavior in pip-23.1 appears to be adding and removing files to build/bdist.linux-x86_64/... as it builds. As our indicators all try to build _delphi_utils_python we get race conditions, missing files, and borked file permissions that cause build failures.

We should assess:

  • What we need to change in the build process to make it so we can use a pip greater than 23.01.
  • Do we need to try to build _delphi_utils_python at all? We don't actually need it to run the indicators in production as they install delphi-utils from pypi.org. Possibly this necessity to try to build _delphi_utils_python is from ancient times and we can get rid of it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant