chore(clippy): make clippy happy

Author: clearloop

src/cmds/pick.rs

@@ -210,7 +210,7 @@ fn closest_named_problem(problems: &Vec<Problem>, lookup_name: &str) -> Option<i
 
 // Longest commong subsequence DP approach O(nm) space and time. Table must be at least
 // (text1.len() + 1) * (text2.len() + 1) length or greater and is mutated every call
-fn longest_common_subsequence(table: &mut Vec<usize>, text1: &str, text2: &str) -> usize {
+fn longest_common_subsequence(table: &mut [usize], text1: &str, text2: &str) -> usize {
     assert!(table.len() >= (text1.len() + 1) * (text2.len() + 1));
     let height: usize = text1.len() + 1;
     let width: usize = text2.len() + 1;

src/config/cookies.rs

@@ -1,7 +1,9 @@
 //! Cookies in config
-use std::str::FromStr;
-
 use serde::{Deserialize, Serialize};
+use std::{
+    fmt::{self, Display},
+    str::FromStr,
+};
 
 #[derive(Clone, Debug, Deserialize, Serialize)]
 pub enum LeetcodeSite {
@@ -22,12 +24,14 @@ impl FromStr for LeetcodeSite {
     }
 }
 
-impl ToString for LeetcodeSite {
-    fn to_string(&self) -> String {
-        match self {
-            LeetcodeSite::LeetcodeCom => "leetcode.com".to_string(),
-            LeetcodeSite::LeetcodeCn => "leetcode.cn".to_string(),
-        }
+impl Display for LeetcodeSite {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let s = match self {
+            LeetcodeSite::LeetcodeCom => "leetcode.com",
+            LeetcodeSite::LeetcodeCn => "leetcode.cn",
+        };
+
+        write!(f, "{s}")
     }
 }
 
@@ -49,8 +53,12 @@ impl Default for Cookies {
     }
 }
 
-impl std::string::ToString for Cookies {
-    fn to_string(&self) -> String {
-        format!("LEETCODE_SESSION={};csrftoken={};", self.session, self.csrf)
+impl Display for Cookies {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        write!(
+            f,
+            "LEETCODE_SESSION={};csrftoken={};",
+            self.session, self.csrf
+        )
     }
 }

src/helper.rs

@@ -87,7 +87,8 @@ mod filter {
         ids.iter().for_each(|x| {
             map.insert(x.to_string(), true).unwrap_or_default();
         });
-        ps.retain(|x| map.get(&x.id.to_string()).is_some());
+
+        ps.retain(|x| map.contains_key(&x.id.to_string()));
         Ok(())
     }
 }

src/plugins/chrome.rs

@@ -3,7 +3,7 @@ use anyhow::anyhow;
 use diesel::prelude::*;
 use keyring::Entry;
 use openssl::{hash, pkcs5, symm};
-use std::collections::HashMap;
+use std::{collections::HashMap, fmt::Display};
 
 /// LeetCode Cookies Schema
 mod schema {
@@ -34,9 +34,13 @@ pub struct Ident {
     session: String,
 }
 
-impl std::string::ToString for Ident {
-    fn to_string(&self) -> String {
-        format!("LEETCODE_SESSION={};csrftoken={};", self.session, self.csrf)
+impl Display for Ident {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(
+            f,
+            "LEETCODE_SESSION={};csrftoken={};",
+            self.session, self.csrf
+        )
     }
 }
 
@@ -64,7 +68,7 @@ pub fn cookies() -> Result<Ident> {
     debug!("Chrome Cookies path is {:?}", &p);
     let mut conn = cache::conn(p.to_string_lossy().to_string());
     let res = cookies
-        .filter(host_key.like(format!("#{}", ccfg.site.to_string())))
+        .filter(host_key.like(format!("#{}", ccfg.site)))
         .load::<Cookies>(&mut conn)
         .expect("Loading cookies from google chrome failed.");
 

src/pym.rs

@@ -16,7 +16,7 @@ pub fn exec(module: &str) -> Result<Vec<String>> {
 
     // pygil
     Python::with_gil(|py| {
-        let pym = PyModule::from_code(py, &script, "plan.py", "plan")?;
+        let pym = PyModule::from_code_bound(py, &script, "plan.py", "plan")?;
         pym.getattr("plan")?.call1((sps, stags))?.extract()
     })
     .map_err(Into::into)