Skip to content

dataframe sort() doesn't exist any more #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandipb opened this issue Sep 26, 2018 · 4 comments
Closed

dataframe sort() doesn't exist any more #40

sandipb opened this issue Sep 26, 2018 · 4 comments
Assignees

Comments

@sandipb
Copy link

sandipb commented Sep 26, 2018

(I have consistently touted this as one of the best tutorials in any topic in programming that I have read. I keep coming back to this every time I have been away from Pandas for a while and have to refresh my memory. Thanks for ever for doing this.)

Perhaps an errata would be helpful to correct for the API changes that have happened so far.

For one, I found out that dataframe .sort() doesnt exist any more and .sort_values() should be used instead.

@brandon-rhodes brandon-rhodes self-assigned this Sep 26, 2018
@brandon-rhodes
Copy link
Owner

Thank you! :) — I'll go back through the notebooks, maybe this weekend, and get them updated and working again. Thanks for pointing out that they've gone out of date! Since they have no tests, there's nothing to alert me when a method they use stops existing.

Fun historical fact: I myself had actually wanted the method to be named "sorted()"

pandas-dev/pandas#9816

@brandon-rhodes
Copy link
Owner

This was resolved, it looks like, in ae4a0e8 — so a fresh checkout of the project should assure that you have up-to-date Pandas code. Thanks again for the kind words, and I'm glad the tutorial has been helpful to you!

@ReddyKilowatt
Copy link

I too am having fun with these notebooks and datasets. This is my first look into data analysis. I was planning on submitting a PR with the notebook updates for recent Pandas, but decided not to. Some people may be using older Pandas, while others like myself are using the latest. I’m not sure the best way to cover both without breaking anything.

@brandon-rhodes
Copy link
Owner

Yes, my approach for the moment is to edit code where necessary but otherwise to not disturb the JSON as long as it keeps working on the most recent version of Pandas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants