Skip to content

Missing impl of general global ops and corresponding nan cases #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehsanmok opened this issue Feb 21, 2018 · 0 comments
Closed

Missing impl of general global ops and corresponding nan cases #418

ehsanmok opened this issue Feb 21, 2018 · 0 comments

Comments

@ehsanmok
Copy link
Contributor

ehsanmok commented Feb 21, 2018

@bluss I'd like to propose implementing min/max and nan_min/nan_max and alike (sum, mean, median) for ndarray to be more compatible with numpy. (I'll create a list of task if confirmed later!)

I have the impl of nan_min/nan_max ready returning Option<A> where None is for empty array, Some(number) if not all are NAN and Some(NAN) if all entries are NAN (f32 or f64). Is that ok or should panic at the last case?

Impl of generic min/max seems non-trivial and needs Any::TypeId checking for float and non-float?

I'd also like to propose changing scalar_sum to sum.

P.S. related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant