Skip to content

Commit e93f789

Browse files
committed
native_deps: give up on testing cc_binary using rust_library
This only works on clang today, and can only work on clang for the near-term. It's not clear how to write a clang-only test in this case, so we just give up for now. "I promise it works!" etc
1 parent 6db880f commit e93f789

File tree

4 files changed

+0
-55
lines changed

4 files changed

+0
-55
lines changed

test/unit/native_deps/alloc_shims.c

Lines changed: 0 additions & 24 deletions
This file was deleted.

test/unit/native_deps/cc_bin_uses_rust_library.cc

Lines changed: 0 additions & 7 deletions
This file was deleted.

test/unit/native_deps/native_deps_test.bzl

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
"""Unittests for rust rules."""
22

33
load("@bazel_skylib//lib:unittest.bzl", "analysistest", "asserts", "unittest")
4-
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
54
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_proc_macro", "rust_shared_library", "rust_static_library")
65

76
def _assert_argv_contains_not(env, action, flag):
@@ -227,25 +226,6 @@ def _native_dep_test():
227226
deps = [":native_dep", ":alwayslink"],
228227
)
229228

230-
cc_library(
231-
name = "alloc_shims",
232-
srcs = ["alloc_shims.c"],
233-
)
234-
235-
rust_library(
236-
name = "print_hi_rust",
237-
srcs = ["print_hi_rust.rs"],
238-
)
239-
240-
cc_binary(
241-
name = "cc_bin_uses_rust_library",
242-
srcs = ["cc_bin_uses_rust_library.cc"],
243-
deps = [
244-
":print_hi_rust",
245-
":alloc_shims", # TODO: this should come in through the toolchain configuration
246-
],
247-
)
248-
249229
rlib_has_no_native_libs_test(
250230
name = "rlib_has_no_native_libs_test",
251231
target_under_test = ":rlib_has_no_native_dep",

test/unit/native_deps/print_hi_rust.rs

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)