Skip to content

Commit e65d388

Browse files
authored
Merge pull request #5313 from aws/fix-sensitivelistmap
fix sensitive missing on list/map
2 parents e8ff775 + 4e433e1 commit e65d388

File tree

47 files changed

+214
-197
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+214
-197
lines changed

CHANGELOG_PENDING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@
55
### SDK Enhancements
66

77
### SDK Bugs
8+
* Apply sensitive struct tag to lists/maps with sensitive members.
9+
* This change propagates existing sensitive protection to lists/maps.

private/model/api/shape.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ func (ref *ShapeRef) GoTags(toplevel bool, isRequired bool) string {
600600
tags = append(tags, ShapeTag{"ignore", "true"})
601601
}
602602

603-
if ref.Shape.Sensitive {
603+
if ref.Shape.IsSensitive() {
604604
tags = append(tags, ShapeTag{"sensitive", "true"})
605605
}
606606

@@ -619,6 +619,21 @@ func (s *Shape) HasPayloadMembers() bool {
619619
return false
620620
}
621621

622+
// IsSensitive checks whether the Shape itself is sensitive, or if the Shape is
623+
// a collection/map with a sensitive member.
624+
func (s *Shape) IsSensitive() bool {
625+
if s.Sensitive {
626+
return true
627+
}
628+
if s.MemberRef.Shape != nil && s.MemberRef.Shape.Sensitive {
629+
return true
630+
}
631+
if s.ValueRef.Shape != nil && s.ValueRef.Shape.Sensitive {
632+
return true
633+
}
634+
return false
635+
}
636+
622637
// Docstring returns the godocs formated documentation
623638
func (ref *ShapeRef) Docstring() string {
624639
if ref.Documentation != "" {

service/appflow/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/applicationdiscoveryservice/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/apprunner/api.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/auditmanager/api.go

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/bedrock/api.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/bedrockagent/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/bedrockagentruntime/api.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/billingconductor/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/chime/api.go

Lines changed: 16 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/chimesdkidentity/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/chimesdkmediapipelines/api.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/chimesdkmessaging/api.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)