Skip to content

Commit a64af84

Browse files
committed
Merge RFC rust-lang#563: remove ndebug support. Also add to index and
add in unresolved questions from the RFC discussion.
1 parent 7b76778 commit a64af84

File tree

2 files changed

+22
-3
lines changed

2 files changed

+22
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ the direction the language is evolving in.
4141
* [0509-collections-reform-part-2.md](text/0509-collections-reform-part-2.md)
4242
* [0517-io-os-reform.md](text/0517-io-os-reform.md)
4343
* [0560-integer-overflow.md](text/0560-integer-overflow.md)
44+
* [0563-remove-ndebug.md](text/0563-remove-ndebug.md)
4445
* [0572-rustc-attribute.md](text/0572-rustc-attribute.md)
4546
* [0702-rangefull-expression.md](text/0702-rangefull-expression.md)
4647
* [0738-variance.md](text/0738-variance.md)

text/0000-remove-ndebug.md renamed to text/0563-remove-ndebug.md

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
- Start Date: (fill me in with today's date, YYYY-MM-DD)
2-
- RFC PR: (leave this empty)
3-
- Rust Issue: (leave this empty)
2+
- RFC PR: [rust-lang/rfcs#563](https://github.com/rust-lang/rfcs/pull/563)
3+
- Rust Issue: [rust-lang/rust#22492](https://github.com/rust-lang/rust/issues/22492)
44

55
# Summary
66

@@ -42,4 +42,22 @@ No real alternatives beyond different names and defaults.
4242

4343
# Unresolved questions
4444

45-
None.
45+
From the RFC discussion there remain some unresolved details:
46+
47+
* brson
48+
[writes](https://github.com/rust-lang/rfcs/pull/563#issuecomment-72549694),
49+
"I have a minor concern that `-C debug-assertions` might not be the
50+
right place for this command line flag - it doesn't really affect
51+
code generation, at least in the current codebase (also `--cfg
52+
debug_assertions` has the same effect).".
53+
* huonw
54+
[writes](https://github.com/rust-lang/rfcs/pull/563#issuecomment-72550619),
55+
"It seems like the flag could be more than just a boolean, but
56+
rather take a list of what to enable to allow fine-grained control,
57+
e.g. none, overflow-checks, debug_cfg,overflow-checks, all. (Where
58+
-C debug-assertions=debug_cfg acts like --cfg debug.)".
59+
* huonw
60+
[writes](https://github.com/rust-lang/rfcs/pull/563#issuecomment-74762795),
61+
"if we want this to apply to more than just debug_assert do we want
62+
to use a name other than -C debug-assertions?".
63+

0 commit comments

Comments
 (0)