Skip to content

Review required for pull request #67 "Bump Node version to 20" #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
latchdevel opened this issue Jun 20, 2024 · 4 comments
Closed
3 tasks done

Review required for pull request #67 "Bump Node version to 20" #69

latchdevel opened this issue Jun 20, 2024 · 4 comments
Labels
conclusion: resolved Issue was resolved type: enhancement Proposed improvement

Comments

@latchdevel
Copy link
Contributor

Describe the request

Pull request #67 is ready for review and merging.

Describe the current behavior

Looking for PR reviewers: @MatteoPologruto, @LArkema, @stefan-b-jakobsson, @per1234

'arduino/setup-arduino-cli' version

arduino/setup-arduino-cli/tree/v1.1.2

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest version
  • My request contains all necessary details
@latchdevel latchdevel added the type: enhancement Proposed improvement label Jun 20, 2024
@stefan-b-jakobsson
Copy link

I can review the PR if there are no other options, but I'm not familiar with the code base from before.

@latchdevel
Copy link
Contributor Author

The changes are minimal, just what is necessary for it work on node v20.
But, anyway, @per1234 or @MatteoPologruto must be merge it to master branch and make a new release.

@alessio-perugini
Copy link
Contributor

Thank you so much for the help, and sorry for the very late response 🙏

Release: https://github.com/arduino/setup-arduino-cli/releases/tag/v2.0.0

@latchdevel
Copy link
Contributor Author

Not at all, thanks to you for all your work and effort.
It is a pleasure to be able to contribute.

@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

4 participants