Skip to content

Commit 9db57ba

Browse files
committed
Move definition of package filename to dedicated step in release workflow
The package filename is referenced in multiple places in the release workflow. In order to avoid code duplication, it is defined once as an environment variable, then that variable referenced in each of the instances where the filename is needed. Previously, this was done by first defining and referencing a shell environment variable at the point of the first usage, then defining a workflow environment variable and referencing that in the second usage. The maintainability and readability of the workflow is improved by using a single workflow environment variable, defined in the step dedicated to defining such variables, then referencing it consistently in all usages.
1 parent da50458 commit 9db57ba

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/release-go-task.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ jobs:
8585
run: |
8686
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
8787
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >> "$GITHUB_ENV"
88+
TAG="${GITHUB_REF/refs\/tags\//}"
89+
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >> $GITHUB_ENV
8890
8991
- name: Checkout repository
9092
uses: actions/checkout@v4
@@ -160,10 +162,7 @@ jobs:
160162
# GitHub's upload/download-artifact actions don't preserve file permissions,
161163
# so we need to add execution permission back until the action is made to do this.
162164
chmod +x "${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"
163-
TAG="${GITHUB_REF/refs\/tags\//}"
164-
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}"
165-
tar -czvf "$PACKAGE_FILENAME" "${{ env.BUILD_FOLDER }}"
166-
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
165+
tar -czvf "${{ env.PACKAGE_FILENAME }}" "${{ env.BUILD_FOLDER }}"
167166
168167
- name: Upload artifact
169168
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)