Incorrect string literal highlighting in dark theme with "%" character

[spacegaier]

Describe the bug
"%" is in red font color instead of the orange that the rest of the string literal uses.

To Reproduce
Steps to reproduce the behavior:

1. Start IDE with dark theme.
2. New INO file with source code: const char* string = "string%withPercent";

Expected behavior
All orange font for string literal.

Screenshots

Desktop (please complete the following information):

• OS: Win 10
• Version 0.0.1

[svenefftinge]

I cannot reproduce this on OSX with the next milestone (v0.0.3).

[spacegaier]

It seems to depend on the actual string literal. Your "foo%test" also works fine for me, but my original test value still has the wrong highlight in v0.0.3 as does a simple value like "a%b". "a%a" however is weirdly fine.

[spoenemann]

That's because the highlighting supports format specifiers used by printf and other standard functions. It does not check whether the string is actually used within a call to printf, but that's a limitation we cannot overcome.