Skip to content

Commit 7ab3a17

Browse files
committed
Add explanatory comment re: release asset upload warning
The subfolders that remain in the Go release system's build output cause a bunch of warnings in the workflow run summary and logs resulting from the step that uploads the archives as release assets: ``` Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_32bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_64bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARM64/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARMv6/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Linux_ARMv7/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_macOS_64bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Windows_32bit/. Directories can not be uploaded to a release. Warning: Artifact is a directory:dist/serial-discovery_0.0.42_Windows_64bit/. Directories can not be uploaded to a release. ``` There is no problem because these subfolders are not intended to be added as release assets and the archives in the root of the dist folder are uploaded, but I think these warnings might cause someone confusion far in the future when nobody remembers exactly how these workflows work and wonders if these warnings indicate something is wrong. I didn't find a clean solution for adjusting the artifacts input glob to exclude the subfolders so I settled on adding an explanatory comment to the workflow.
1 parent 105d08f commit 7ab3a17

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

.github/workflows/release-go-task.yml

+2
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,8 @@ jobs:
151151
bodyFile: ${{ env.DIST_DIR }}/CHANGELOG.md
152152
draft: false
153153
prerelease: ${{ steps.prerelease.outputs.IS_PRE }}
154+
# NOTE: "Artifact is a directory" warnings are expected and don't indicate a problem
155+
# (all the files we need are in the DIST_DIR root)
154156
artifacts: ${{ env.DIST_DIR }}/*
155157

156158
- name: Upload release files on Arduino downloads servers

0 commit comments

Comments
 (0)