From 2e94a4cdffe56d52fd3f581b5d38ec5754124f13 Mon Sep 17 00:00:00 2001 From: Francesco Spissu Date: Tue, 22 Mar 2022 16:11:00 +0100 Subject: [PATCH 1/4] add notes for Windows contributor in BUILDING.md --- BUILDING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BUILDING.md b/BUILDING.md index a9e10f47e..0e6a590d6 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -82,6 +82,10 @@ This project is built on [GitHub Actions](https://github.com/arduino/arduino-ide git push origin 1.2.3 ``` +## Notes for Windows contributors +In case the build does not succeded it's possible that you have to install Microsoft Visual C++ (MSVC) compiler toolset. You can download it from the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#other) selecting Build Tools for Visual Studio 20XX. Then you have to install Desktop development with C++. + + ## Notes for macOS contributors Beginning in macOS 10.14.5, the software [must be notarized to run](https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution). The signing and notarization processes for the Arduino IDE are managed by our Continuous Integration (CI) workflows, implemented with GitHub Actions. On every push and pull request, the Arduino IDE is built and saved to a workflow artifact. These artifacts can be used by contributors and beta testers who don't want to set up a build system locally. For security reasons, signing and notarization are disabled for workflow runs for pull requests from forks of this repository. This means that macOS will block you from running those artifacts. From 5e1d0d00c8f30c0299b68b27c6318aa07e858848 Mon Sep 17 00:00:00 2001 From: Francesco Spissu Date: Wed, 23 Mar 2022 09:32:38 +0100 Subject: [PATCH 2/4] rephrase notes for Windows contributor in BUILDING.md --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 0e6a590d6..931c12187 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -83,7 +83,7 @@ This project is built on [GitHub Actions](https://github.com/arduino/arduino-ide ``` ## Notes for Windows contributors -In case the build does not succeded it's possible that you have to install Microsoft Visual C++ (MSVC) compiler toolset. You can download it from the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#other) selecting Build Tools for Visual Studio 20XX. Then you have to install Desktop development with C++. +Windows requires Microsoft Visual C++ (MSVC) compiler toolset to be installed on your development machine. In case it's not already present, it can be downloaded from the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#other) selecting Build Tools for Visual Studio 20XX. It is important to enable Desktop development with C++ workload during the installation procedure. ## Notes for macOS contributors From ebdb5dc345d69c0b596c622097e3f1cbcc389495 Mon Sep 17 00:00:00 2001 From: Francesco Spissu <94986937+francescospissu@users.noreply.github.com> Date: Wed, 23 Mar 2022 14:36:55 +0100 Subject: [PATCH 3/4] Update notes for Windows contributor in BUILDING.md Co-authored-by: per1234 --- BUILDING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index 931c12187..07fa5ee3c 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -83,7 +83,11 @@ This project is built on [GitHub Actions](https://github.com/arduino/arduino-ide ``` ## Notes for Windows contributors -Windows requires Microsoft Visual C++ (MSVC) compiler toolset to be installed on your development machine. In case it's not already present, it can be downloaded from the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#other) selecting Build Tools for Visual Studio 20XX. It is important to enable Desktop development with C++ workload during the installation procedure. +Windows requires the Microsoft Visual C++ (MSVC) compiler toolset to be installed on your development machine. + +In case it's not already present, it can be downloaded from the "**Tools for Visual Studio 20XX**" section of the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2022) via the "**Build Tools for Visual Studio 20XX**" (e.g., "**Build Tools for Visual Studio 2022**") download link. + +Select "**Desktop development with C++**" from the "**Workloads**" tab during the installation procedure. ## Notes for macOS contributors From 5adbcdb086210302adf7b10486386e11d44c3456 Mon Sep 17 00:00:00 2001 From: Francesco Spissu Date: Wed, 23 Mar 2022 15:34:16 +0100 Subject: [PATCH 4/4] move Notes for Windows contributors in Build from source section --- BUILDING.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index 07fa5ee3c..ed13b2e93 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -66,6 +66,13 @@ Once you have all the tools installed, you can build the editor following these yarn start ``` +### Notes for Windows contributors +Windows requires the Microsoft Visual C++ (MSVC) compiler toolset to be installed on your development machine. + +In case it's not already present, it can be downloaded from the "**Tools for Visual Studio 20XX**" section of the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2022) via the "**Build Tools for Visual Studio 20XX**" (e.g., "**Build Tools for Visual Studio 2022**") download link. + +Select "**Desktop development with C++**" from the "**Workloads**" tab during the installation procedure. + ### CI This project is built on [GitHub Actions](https://github.com/arduino/arduino-ide/actions). @@ -82,13 +89,6 @@ This project is built on [GitHub Actions](https://github.com/arduino/arduino-ide git push origin 1.2.3 ``` -## Notes for Windows contributors -Windows requires the Microsoft Visual C++ (MSVC) compiler toolset to be installed on your development machine. - -In case it's not already present, it can be downloaded from the "**Tools for Visual Studio 20XX**" section of the Visual Studio [downloads page](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2022) via the "**Build Tools for Visual Studio 20XX**" (e.g., "**Build Tools for Visual Studio 2022**") download link. - -Select "**Desktop development with C++**" from the "**Workloads**" tab during the installation procedure. - ## Notes for macOS contributors Beginning in macOS 10.14.5, the software [must be notarized to run](https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution). The signing and notarization processes for the Arduino IDE are managed by our Continuous Integration (CI) workflows, implemented with GitHub Actions. On every push and pull request, the Arduino IDE is built and saved to a workflow artifact. These artifacts can be used by contributors and beta testers who don't want to set up a build system locally.