Fix crash when running LibraryPropertiesNameFieldGTRecommendedLength check function

per1234 · per1234 · commit b64c91114e80 · 2020-11-26T03:56:26.000-08:00
A copy/paste error resulted in a crash when the check function was run on a library with invalid library.properties.
diff --git a/check/checkfunctions/library.go b/check/checkfunctions/library.go
@@ -92,7 +92,7 @@ func LibraryPropertiesNameFieldGTMaxLength() (result checkresult.Type, output st
 // LibraryPropertiesNameFieldGTRecommendedLength checks if the library.properties "name" value is greater than the recommended length.
 func LibraryPropertiesNameFieldGTRecommendedLength() (result checkresult.Type, output string) {
 	if checkdata.LibraryPropertiesLoadError() != nil {
-		return checkresult.NotRun, checkdata.LibraryProperties().Get("name")
+		return checkresult.NotRun, ""
 	}
 
 	name, ok := checkdata.LibraryProperties().GetOk("name")

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ func LibraryPropertiesNameFieldGTMaxLength() (result checkresult.Type, output st`
`92`	`92`	`// LibraryPropertiesNameFieldGTRecommendedLength checks if the library.properties "name" value is greater than the recommended length.`
`93`	`93`	`func LibraryPropertiesNameFieldGTRecommendedLength() (result checkresult.Type, output string) {`
`94`	`94`	`if checkdata.LibraryPropertiesLoadError() != nil {`
`95`		`- return checkresult.NotRun, checkdata.LibraryProperties().Get("name")`
	`95`	`+ return checkresult.NotRun, ""`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`name, ok := checkdata.LibraryProperties().GetOk("name")`