Skip to content

Commit 161e3dd

Browse files
Reduce quoting using verbatim strings and improve jq queries
Co-authored-by: Cristian Maglie <[email protected]>
1 parent 858aa3e commit 161e3dd

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

internal/integrationtest/lib/lib_test.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ func TestList(t *testing.T) {
323323
stdout, stderr, err := cli.Run("lib", "list")
324324
require.NoError(t, err)
325325
require.Empty(t, stderr)
326-
require.Contains(t, strings.TrimSpace(string(stdout)), "No libraries installed.")
326+
require.Contains(t, string(stdout), "No libraries installed.")
327327
stdout, stderr, err = cli.Run("lib", "list", "--format", "json")
328328
require.NoError(t, err)
329329
require.Empty(t, stderr)
@@ -338,11 +338,11 @@ func TestList(t *testing.T) {
338338
require.NoError(t, err)
339339
require.Empty(t, stderr)
340340
lines := strings.Split(strings.TrimSpace(string(stdout)), "\n")
341-
require.Equal(t, 2, len(lines))
341+
require.Len(t, lines, 2)
342342
lines[1] = strings.Join(strings.Fields(lines[1]), " ")
343343
toks := strings.SplitN(lines[1], " ", 5)
344344
// Verifies the expected number of field
345-
require.Equal(t, 5, len(toks))
345+
require.Len(t, toks, 5)
346346
// be sure line contain the current version AND the available version
347347
require.NotEmpty(t, toks[1])
348348
require.NotEmpty(t, toks[2])
@@ -355,7 +355,7 @@ func TestList(t *testing.T) {
355355
require.Empty(t, stderr)
356356
requirejson.Len(t, stdout, 1)
357357
// be sure data contains the available version
358-
requirejson.Query(t, stdout, ".[0] | .release | .version != \"\"", "true")
358+
requirejson.Query(t, stdout, `.[0] | .release | .version != ""`, "true")
359359

360360
// Install something we can list without provides_includes field given in library.properties
361361
_, _, err = cli.Run("lib", "install", "[email protected]")
@@ -366,7 +366,7 @@ func TestList(t *testing.T) {
366366
require.Empty(t, stderr)
367367
requirejson.Len(t, stdout, 1)
368368
// be sure data contains the correct provides_includes field
369-
requirejson.Query(t, stdout, ".[0] | .library | .provides_includes | .[0]", "\"Arduino_APDS9960.h\"")
369+
requirejson.Query(t, stdout, ".[0] | .library | .provides_includes | .[0]", `"Arduino_APDS9960.h"`)
370370
}
371371

372372
func TestListExitCode(t *testing.T) {
@@ -445,8 +445,8 @@ func TestListWithFqbn(t *testing.T) {
445445
requirejson.Len(t, stdout, 1)
446446

447447
// Verifies library is compatible
448-
requirejson.Query(t, stdout, ".[0] | .library | .name", "\"ArduinoJson\"")
449-
requirejson.Query(t, stdout, ".[0] | .library | .compatible_with | .\"arduino:avr:uno\"", "true")
448+
requirejson.Query(t, stdout, `.[0] | .library | .name`, `"ArduinoJson"`)
449+
requirejson.Query(t, stdout, `.[0] | .library | .compatible_with | ."arduino:avr:uno"`, `true`)
450450
}
451451

452452
func TestListProvidesIncludesFallback(t *testing.T) {
@@ -550,7 +550,7 @@ func TestInstallLibraryWithDependencies(t *testing.T) {
550550
// Verifies library's dependencies are correctly installed
551551
stdout, _, err = cli.Run("lib", "list", "--format", "json")
552552
require.NoError(t, err)
553-
requirejson.Query(t, stdout, "[ .[] | .library | .name ] | sort", "[\"MD_MAX72XX\",\"MD_Parola\"]")
553+
requirejson.Query(t, stdout, `[ .[] | .library | .name ] | sort`, `["MD_MAX72XX","MD_Parola"]`)
554554

555555
// Try upgrading with --no-overwrite (should fail) and without --no-overwrite (should succeed)
556556
_, _, err = cli.Run("lib", "install", "[email protected]", "--no-overwrite")
@@ -588,7 +588,7 @@ func TestInstallNoDeps(t *testing.T) {
588588
// Verifies library's dependencies are not installed
589589
stdout, _, err = cli.Run("lib", "list", "--format", "json")
590590
require.NoError(t, err)
591-
requirejson.Query(t, stdout, ".[] | .library | .name", "\"MD_Parola\"")
591+
requirejson.Query(t, stdout, `.[] | .library | .name`, `"MD_Parola"`)
592592
}
593593

594594
func TestInstallWithGitUrl(t *testing.T) {

0 commit comments

Comments
 (0)