Skip to content

Commit 0708bf9

Browse files
authored
Merge pull request #12 from AlbyIanna/AlbyIanna/NBConnectionHandler-optional-values
Add overloaded constructors for optional apn, login and pass in NBConnectionHandler
2 parents 36cb677 + 8501341 commit 0708bf9

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

src/Arduino_NBConnectionHandler.cpp

+12-2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,16 @@ static const unsigned long NETWORK_CONNECTION_INTERVAL = 30000;
4141
/******************************************************************************
4242
CTOR/DTOR
4343
******************************************************************************/
44+
NBConnectionHandler::NBConnectionHandler(const char *pin, const char *apn, const char *login, const char *pass, bool _keepAlive) :
45+
login(login),
46+
pass(pass) {
47+
NBConnectionHandler(pin, apn, _keepAlive);
48+
}
49+
50+
NBConnectionHandler::NBConnectionHandler(const char *pin, const char *apn, bool _keepAlive) :
51+
apn(apn) {
52+
NBConnectionHandler(pin, _keepAlive);
53+
}
4454

4555
NBConnectionHandler::NBConnectionHandler(const char *pin, bool _keepAlive) :
4656
pin(pin),
@@ -58,7 +68,7 @@ NBConnectionHandler::NBConnectionHandler(const char *pin, bool _keepAlive) :
5868

5969
void NBConnectionHandler::init() {
6070
char msgBuffer[120];
61-
if (nbAccess.begin(pin) == NB_READY) {
71+
if (nbAccess.begin(pin, apn, login, pass) == NB_READY) {
6272
Debug.print(DBG_INFO, "SIM card ok");
6373
nbAccess.setTimeout(CHECK_INTERVAL_RETRYING);
6474
changeConnectionState(NetworkConnectionState::CONNECTING);
@@ -113,7 +123,7 @@ void NBConnectionHandler::update() {
113123
case NetworkConnectionState::CONNECTING: {
114124
// NOTE: Blocking Call when 4th parameter == true
115125
NB_NetworkStatus_t networkStatus;
116-
networkStatus = gprs.attachGPRS();
126+
networkStatus = gprs.attachGPRS(true);
117127
Debug.print(DBG_DEBUG, "GPRS.attachGPRS(): %d", networkStatus);
118128
if (networkStatus == NB_NetworkStatus_t::ERROR) {
119129
// NO FURTHER ACTION WILL FOLLOW THIS

src/Arduino_NBConnectionHandler.h

+2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@
3333
class NBConnectionHandler : public ConnectionHandler {
3434
public:
3535
NBConnectionHandler(const char *pin, const bool keepAlive = true);
36+
NBConnectionHandler(const char *pin, const char *apn, const bool keepAlive = true);
37+
NBConnectionHandler(const char *pin, const char *apn, const char *login, const char *pass, const bool keepAlive = true);
3638

3739
virtual void init();
3840
virtual unsigned long getTime();

0 commit comments

Comments
 (0)