Skip to content

Commit d8182d4

Browse files
Remove netgo build tag for Windows to disable new Go resolver behaviour (#352)
In go1.19 there is no support for 'hosts' file for Windows: golang/go#57757 Disabling netgo will revert behaviour to go1.18 for resolving names
1 parent ccbffba commit d8182d4

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
- Improve deprecated notice for old passthrough flags
55
- Improve detection of arangod binary when running local installation (use --server.use-local-bin)
66
- Upgrade base Alpine image and Go dependencies to fix CVEs
7+
- Remove `netgo` build tag for Windows to disable new Go resolver behaviour: https://github.com/golang/go/issues/57757
78

89
## [0.15.6](https://github.com/arangodb-helper/arangodb/tree/0.15.6) (2023-01-20)
910
- Fix restarting cluster with arangosync enabled

Makefile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,11 @@ binaries-test:
162162

163163
$(BIN): $(GOBUILDDIR) $(GO_SOURCES)
164164
@mkdir -p $(BINDIR)
165+
ifeq ($(GOOS),windows)
166+
$(DOCKER_CMD) go build -ldflags "-X main.projectVersion=$(VERSION) -X main.projectBuild=$(COMMIT)" -o "$(BUILD_BIN)" .
167+
else
165168
$(DOCKER_CMD) go build -installsuffix netgo -tags netgo -ldflags "-X main.projectVersion=$(VERSION) -X main.projectBuild=$(COMMIT)" -o "$(BUILD_BIN)" .
169+
endif
166170

167171
$(TESTBIN): $(GOBUILDDIR) $(TEST_SOURCES) $(BIN)
168172
@mkdir -p $(BINDIR)

0 commit comments

Comments
 (0)