Skip to content

Revisit float/double to string transforms (JSON and TextFormat) #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomasvl opened this issue May 29, 2018 · 1 comment
Closed

Revisit float/double to string transforms (JSON and TextFormat) #752

thomasvl opened this issue May 29, 2018 · 1 comment

Comments

@thomasvl
Copy link
Collaborator

@tbkka has been landing some code to the Swift StandardLib to speed up the float and double formatting. Float.description should now avoid the heap, but Double.description does still use the heap.

We should revisit current releases with our perf harness to see if we can move our code into a conditional block for old versions of Swift, to eventually phase it out.
@tbkka tbkka mentioned this issue Jun 4, 2019
Merged
@tbkka
Copy link
Collaborator

tbkka commented Jun 4, 2019

Resolved via #882.

@tbkka tbkka closed this as completed Jun 4, 2019
@tbkka tbkka mentioned this issue Jun 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasvl @tbkka