Skip to content

Service is broken in external HTML templates with CLI 1.1.0 #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyrilletuzi opened this issue Jun 1, 2017 · 2 comments
Closed

Service is broken in external HTML templates with CLI 1.1.0 #102

cyrilletuzi opened this issue Jun 1, 2017 · 2 comments

Comments

@cyrilletuzi
Copy link

Bug Report or Feature Request (mark with an x)

- [x] bug report 

Versions.

cli 1.1.0
VS Code Angular Language Service 0.1.3

Repro steps.

  1. Use VS Code with official Angular Language Service plugin installed.
  2. Create a project with CLI : ng new app
  3. Completion and error checking in HTML templates doesn't work.
  4. npm uninstall @angular/language-service
  5. Restart VS Code.
  6. Now it works.

Desired functionality.

VS Code Angular Language Service plugin seems to use :

  • it's own install of @angular/language-service if it's not present in node_modules
  • if present, it uses the project dependency, and unfortunately, the plugin is not always up to date with the last release of @angular/language-service.

Angular CLI last 1.1.0 now installs @angular/language-service by default, so it's broken.

I've open the same issue in angular/angular-cli#6536 as I'm not sure which side should correct.

@cyrilletuzi
Copy link
Author

Closing, as it seems to be OK with last versions.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant